Skip to content

[lldb] Fix lldb-dotest.in to use args determined by CMake #124811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link
Contributor

This change is required as a result of the changes made in D132642
(bb26ebb).

This change is required as a result of the changes made in D132642
(bb26ebb).
@llvmbot
Copy link
Member

llvmbot commented Jan 28, 2025

@llvm/pr-subscribers-lldb

Author: Dave Lee (kastiglione)

Changes

This change is required as a result of the changes made in D132642
(bb26ebb).


Full diff: https://github.com/llvm/llvm-project/pull/124811.diff

1 Files Affected:

  • (modified) lldb/utils/lldb-dotest/lldb-dotest.in (+6-3)
diff --git a/lldb/utils/lldb-dotest/lldb-dotest.in b/lldb/utils/lldb-dotest/lldb-dotest.in
index f20859e87b1e0b..9688b94d918429 100755
--- a/lldb/utils/lldb-dotest/lldb-dotest.in
+++ b/lldb/utils/lldb-dotest/lldb-dotest.in
@@ -4,7 +4,8 @@ import subprocess
 import sys
 
 dotest_path = '@LLDB_SOURCE_DIR_CONFIGURED@/test/API/dotest.py'
-dotest_args_str = '@LLDB_DOTEST_ARGS_CONFIGURED@'
+dotest_common_args_str = '@LLDB_TEST_COMMON_ARGS_CONFIGURED@'
+dotest_user_args_str = '@LLDB_TEST_USER_ARGS_CONFIGURED@'
 arch = '@LLDB_TEST_ARCH@'
 executable = '@LLDB_TEST_EXECUTABLE_CONFIGURED@'
 compiler = '@LLDB_TEST_COMPILER_CONFIGURED@'
@@ -26,8 +27,10 @@ if __name__ == '__main__':
     dotest_args = []
     # split on an empty string will produce [''] and if you
     # add that to the command, it will be treated as a directory...
-    if len(dotest_args_str) > 0:
-        dotest_args = dotest_args_str.split(';')
+    if dotest_common_args_str:
+        dotest_args.extend(dotest_common_args_str.split(';'))
+    if dotest_user_args_str:
+        dotest_args.extend(dotest_user_args_str.split(';'))
     # Build dotest.py command.
     cmd = [sys.executable, dotest_path]
     cmd.extend(['--arch', arch])

@kastiglione
Copy link
Contributor Author

the build failures are unrelated (clang/Driver/Options.td)

@kastiglione kastiglione merged commit e89e7c4 into llvm:main Jan 28, 2025
7 of 9 checks passed
@kastiglione kastiglione deleted the lldb-Fix-lldb-dotest.in-to-use-args-determined-by-CMake branch January 28, 2025 21:36
kastiglione added a commit to swiftlang/llvm-project that referenced this pull request Jan 28, 2025
This change is required as a result of the changes made in D132642
(bb26ebb).

(cherry picked from commit e89e7c4)
kastiglione added a commit to swiftlang/llvm-project that referenced this pull request Jan 29, 2025
This change is required as a result of the changes made in D132642
(bb26ebb).

(cherry picked from commit e89e7c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants