Skip to content

[flang] Allow defined assignment to CLASS(*) #124817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions flang/lib/Semantics/tools.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,6 @@ Tristate IsDefinedAssignment(
if (!lhsType || !rhsType) {
return Tristate::No; // error or rhs is untyped
}
if (lhsType->IsUnlimitedPolymorphic()) {
return Tristate::No;
}
if (rhsType->IsUnlimitedPolymorphic()) {
return Tristate::Maybe;
}
TypeCategory lhsCat{lhsType->category()};
TypeCategory rhsCat{rhsType->category()};
if (rhsRank > 0 && lhsRank != rhsRank) {
Expand Down
46 changes: 46 additions & 0 deletions flang/test/Semantics/bug124621.f90
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
! RUN: %python %S/test_errors.py %s %flang_fc1
module m
type t1
contains
procedure, pass(from) :: defAsst1
generic :: assignment(=) => defAsst1
end type
type t2
end type
type t3
end type
interface assignment(=)
module procedure defAsst2
end interface
contains
subroutine defAsst1(to,from)
class(*), intent(out) :: to
class(t1), intent(in) :: from
end
subroutine defAsst2(to,from)
class(*), intent(out) :: to
class(t2), intent(in) :: from
end
end

program test
use m
type(t1) x1
type(t2) x2
type(t3) x3
j = x1
j = x2
!ERROR: No intrinsic or user-defined ASSIGNMENT(=) matches operand types INTEGER(4) and TYPE(t3)
j = x3
x1 = x1
x1 = x2
!ERROR: No intrinsic or user-defined ASSIGNMENT(=) matches operand types TYPE(t1) and TYPE(t3)
x1 = x3
x2 = x1
x2 = x2
!ERROR: No intrinsic or user-defined ASSIGNMENT(=) matches operand types TYPE(t2) and TYPE(t3)
x2 = x3
x3 = x1
x3 = x2
x3 = x3
end