Skip to content

[clang] UEFI handle unsupported triples. #124824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 29, 2025
Merged

[clang] UEFI handle unsupported triples. #124824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
270c260
[clang] Abort on unsupported uefi triples.
Prabhuk Jan 28, 2025
8b5cdb3
Fix formatting
Prabhuk Jan 28, 2025
4ad5294
Replace fatal error with diagnostic error message
Prabhuk Jan 28, 2025
aaed758
fix formatting
Prabhuk Jan 29, 2025
cb22bb6
Add tests
Prabhuk Jan 29, 2025
2a9652d
Duplicate clang_cl tests for clang
Prabhuk Jan 29, 2025
3916cba
Move tests to an existing file
Prabhuk Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clang/lib/Driver/Driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,10 @@ static llvm::Triple computeTargetTriple(const Driver &D,
}
}

// Currently the only architecture supported by *-uefi triples are x86_64.
if (Target.isUEFI() && Target.getArch() != llvm::Triple::x86_64)
D.Diag(diag::err_target_unknown_triple) << Target.str();

// The `-maix[32|64]` flags are only valid for AIX targets.
if (Arg *A = Args.getLastArgNoClaim(options::OPT_maix32, options::OPT_maix64);
A && !Target.isOSAIX())
Expand Down
2 changes: 2 additions & 0 deletions clang/test/Driver/uefi-constructed-args.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// RUN: %clang -### --target=x86_64-unknown-uefi -g -- %s 2>&1 \
// RUN: | FileCheck -check-prefixes=CHECK %s
// RUN: %clang_cl -### --target=x86_64-unknown-uefi -g -- %s 2>&1 \
// RUN: | FileCheck -check-prefixes=CHECK %s
// CHECK: "-cc1"
Expand Down
18 changes: 18 additions & 0 deletions clang/test/Driver/unsupported-target-arch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,21 @@
// RUN: not %clang --target=powerpc-apple-darwin -o /dev/null %s 2> %t.err
// RUN: FileCheck --input-file=%t.err --check-prefix=CHECK-PPCMAC %s
// CHECK-PPCMAC: error: unknown target triple 'unknown-apple-macosx{{.*}}'

// RUN: not %clang --target=aarch64-unknown-uefi -o %t.o %s 2> %t.err
// RUN: FileCheck --input-file=%t.err --check-prefix=CHECK-AARCH64 %s
// RUN: not %clang_cl --target=aarch64-unknown-uefi -o %t.o %s 2> %t.err
// RUN: FileCheck --input-file=%t.err --check-prefix=CHECK-AARCH64 %s
// CHECK-AARCH64: error: unknown target triple 'aarch64-unknown-uefi'{{$}}

// RUN: not %clang --target=arm-unknown-uefi -o %t.o %s 2> %t.err
// RUN: FileCheck --input-file=%t.err -check-prefixes=CHECK-ARM %s
// RUN: not %clang_cl --target=arm-unknown-uefi -o %t.o %s 2> %t.err
// RUN: FileCheck --input-file=%t.err -check-prefixes=CHECK-ARM %s
// CHECK-ARM: error: unknown target triple 'arm-unknown-uefi'{{$}}

// RUN: not %clang --target=x86-unknown-uefi -o %t.o %s 2> %t.err
// RUN: FileCheck --input-file=%t.err -check-prefixes=CHECK-x86 %s
// RUN: not %clang_cl --target=x86-unknown-uefi -o %t.o %s 2> %t.err
// RUN: FileCheck --input-file=%t.err -check-prefixes=CHECK-x86 %s
// CHECK-x86: error: unknown target triple 'x86-unknown-uefi'{{$}}