[libc] Fix conversion warnings for float16 tests. #124830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-libc Author: None (lntue) ChangesFull diff: https://github.com/llvm/llvm-project/pull/124830.diff 4 Files Affected:
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index e4501eb75fa48a..e0cb531b404216 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -45,6 +45,7 @@ add_fp_unittest(
DEPENDS
libc.src.errno.errno
libc.src.math.cospif16
+ libc.src.__support.FPUtil.cast
)
add_fp_unittest(
@@ -69,6 +70,7 @@ add_fp_unittest(
DEPENDS
libc.src.errno.errno
libc.src.math.sinf16
+ libc.src.__support.FPUtil.cast
)
add_fp_unittest(
@@ -1251,6 +1253,7 @@ add_fp_unittest(
libc.hdr.fenv_macros
libc.src.errno.errno
libc.src.math.exp2m1f16
+ libc.src.__support.FPUtil.cast
)
add_fp_unittest(
diff --git a/libc/test/src/math/smoke/cospif16_test.cpp b/libc/test/src/math/smoke/cospif16_test.cpp
index f6d7483393191f..135267ab2ae6f2 100644
--- a/libc/test/src/math/smoke/cospif16_test.cpp
+++ b/libc/test/src/math/smoke/cospif16_test.cpp
@@ -6,6 +6,7 @@
//
//===----------------------------------------------------------------------===//
+#include "src/__support/FPUtil/cast.h"
#include "src/errno/libc_errno.h"
#include "src/math/cospif16.h"
#include "test/UnitTest/FPMatcher.h"
@@ -19,10 +20,10 @@ TEST_F(LlvmLibcCospif16Test, SpecialNumbers) {
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::cospif16(aNaN));
EXPECT_MATH_ERRNO(0);
- EXPECT_FP_EQ(1.0f, LIBC_NAMESPACE::cospif16(zero));
+ EXPECT_FP_EQ(FPBits::one().get_val(), LIBC_NAMESPACE::cospif16(zero));
EXPECT_MATH_ERRNO(0);
- EXPECT_FP_EQ(1.0f, LIBC_NAMESPACE::cospif16(neg_zero));
+ EXPECT_FP_EQ(FPBits::one().get_val(), LIBC_NAMESPACE::cospif16(neg_zero));
EXPECT_MATH_ERRNO(0);
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::cospif16(inf));
@@ -33,12 +34,24 @@ TEST_F(LlvmLibcCospif16Test, SpecialNumbers) {
}
TEST_F(LlvmLibcCospif16Test, Integers) {
- EXPECT_FP_EQ(1.0f, LIBC_NAMESPACE::cospif16(-0x420));
- EXPECT_FP_EQ(1.0f, LIBC_NAMESPACE::cospif16(-0x1.4p+14));
- EXPECT_FP_EQ(-1.0f, LIBC_NAMESPACE::cospif16(0x421));
- EXPECT_FP_EQ(-1.0f, LIBC_NAMESPACE::cospif16(0x333));
- EXPECT_FP_EQ(zero, LIBC_NAMESPACE::cospif16(-0x1.28p4));
- EXPECT_FP_EQ(zero, LIBC_NAMESPACE::cospif16(-0x1.ffcp9));
- EXPECT_FP_EQ(zero, LIBC_NAMESPACE::cospif16(0x1.01p7));
- EXPECT_FP_EQ(zero, LIBC_NAMESPACE::cospif16(0x1.f6cp9));
+ EXPECT_FP_EQ(FPBits::one().get_val(),
+ LIBC_NAMESPACE::cospif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(-0x420.0p0)));
+ EXPECT_FP_EQ(FPBits::one().get_val(),
+ LIBC_NAMESPACE::cospif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(-0x1.4p+14)));
+ EXPECT_FP_EQ(FPBits::one(Sign::NEG).get_val(),
+ LIBC_NAMESPACE::cospif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(0x421.0p0)));
+ EXPECT_FP_EQ(FPBits::one(Sign::NEG).get_val(),
+ LIBC_NAMESPACE::cospif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(0x333.0p0)));
+ EXPECT_FP_EQ(zero, LIBC_NAMESPACE::cospif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(-0x1.28p4)));
+ EXPECT_FP_EQ(zero, LIBC_NAMESPACE::cospif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(-0x1.ffcp9)));
+ EXPECT_FP_EQ(zero, LIBC_NAMESPACE::cospif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(0x1.01p7)));
+ EXPECT_FP_EQ(zero, LIBC_NAMESPACE::cospif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(0x1.f6cp9)));
}
diff --git a/libc/test/src/math/smoke/exp2m1f16_test.cpp b/libc/test/src/math/smoke/exp2m1f16_test.cpp
index 8be86973f32134..f423196a70360d 100644
--- a/libc/test/src/math/smoke/exp2m1f16_test.cpp
+++ b/libc/test/src/math/smoke/exp2m1f16_test.cpp
@@ -7,6 +7,7 @@
//===----------------------------------------------------------------------===//
#include "hdr/fenv_macros.h"
+#include "src/__support/FPUtil/cast.h"
#include "src/errno/libc_errno.h"
#include "src/math/exp2m1f16.h"
#include "test/UnitTest/FPMatcher.h"
@@ -44,7 +45,7 @@ TEST_F(LlvmLibcExp2m1f16Test, Overflow) {
FE_OVERFLOW | FE_INEXACT);
EXPECT_MATH_ERRNO(ERANGE);
- float16 x = 16.0;
+ float16 x = LIBC_NAMESPACE::fputil::cast<float16>(16.0);
EXPECT_FP_EQ_WITH_EXCEPTION_ROUNDING_NEAREST(
inf, LIBC_NAMESPACE::exp2m1f16(x), FE_OVERFLOW | FE_INEXACT);
@@ -69,9 +70,11 @@ TEST_F(LlvmLibcExp2m1f16Test, ResultNearNegOne) {
EXPECT_FP_EQ_WITH_EXCEPTION(-1.0, LIBC_NAMESPACE::exp2m1f16(neg_max_normal),
FE_INEXACT);
- EXPECT_FP_EQ_ALL_ROUNDING(-0x1.ffcp-1, LIBC_NAMESPACE::exp2m1f16(-11.0));
+ EXPECT_FP_EQ_ALL_ROUNDING(
+ -0x1.ffcp-1,
+ LIBC_NAMESPACE::exp2m1f16(LIBC_NAMESPACE::fputil::cast<float16>(-11.0)));
- float16 x = -12.0;
+ float16 x = LIBC_NAMESPACE::fputil::cast<float16>(-12.0);
EXPECT_FP_EQ_WITH_EXCEPTION_ROUNDING_NEAREST(
-1.0, LIBC_NAMESPACE::exp2m1f16(x), FE_INEXACT);
diff --git a/libc/test/src/math/smoke/sinpif16_test.cpp b/libc/test/src/math/smoke/sinpif16_test.cpp
index 0bcd38a60d8499..a79fd5281ee68b 100644
--- a/libc/test/src/math/smoke/sinpif16_test.cpp
+++ b/libc/test/src/math/smoke/sinpif16_test.cpp
@@ -6,6 +6,7 @@
//
//===----------------------------------------------------------------------===//
+#include "src/__support/FPUtil/cast.h"
#include "src/errno/libc_errno.h"
#include "src/math/sinpif16.h"
#include "test/UnitTest/FPMatcher.h"
@@ -33,10 +34,18 @@ TEST_F(LlvmLibcSinpif16Test, SpecialNumbers) {
}
TEST_F(LlvmLibcSinpif16Test, Integers) {
- EXPECT_FP_EQ(neg_zero, LIBC_NAMESPACE::sinpif16(-0x420));
- EXPECT_FP_EQ(neg_zero, LIBC_NAMESPACE::sinpif16(-0x1p+10));
- EXPECT_FP_EQ(neg_zero, LIBC_NAMESPACE::sinpif16(-0x1.4p+14));
- EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(0x420));
- EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(0x1.cp+15));
- EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(0x1.cp+7));
+ EXPECT_FP_EQ(neg_zero,
+ LIBC_NAMESPACE::sinpif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(-0x420.0p0)));
+ EXPECT_FP_EQ(neg_zero, LIBC_NAMESPACE::sinpif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(-0x1p+10)));
+ EXPECT_FP_EQ(neg_zero,
+ LIBC_NAMESPACE::sinpif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(-0x1.4p+14)));
+ EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(0x420.0p0)));
+ EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(0x1.cp+15)));
+ EXPECT_FP_EQ(zero, LIBC_NAMESPACE::sinpif16(
+ LIBC_NAMESPACE::fputil::cast<float16>(0x1.cp+7)));
}
|
|
cc: @wldfngrs |
nickdesaulniers
approved these changes
Jan 28, 2025
|
Are you able to re-run the failing presubmit? Looks like a flake. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/21244 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124801.