Skip to content

[NVPTX] Support for fence.acquire and fence.release #124865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions llvm/lib/Target/NVPTX/NVPTXISelDAGToDAG.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -648,9 +648,50 @@ static unsigned int getFenceOp(NVPTX::Ordering O, NVPTX::Scope S,
if (S == NVPTX::Scope::Cluster)
T->failIfClustersUnsupported(".cluster scope fence");

// Fall back to .acq_rel if .acquire, .release is not supported.
if (!T->hasSplitAcquireAndReleaseFences() &&
(O == NVPTX::Ordering::Acquire || O == NVPTX::Ordering::Release))
O = NVPTX::Ordering::AcquireRelease;

switch (O) {
case NVPTX::Ordering::Acquire:
switch (S) {
case NVPTX::Scope::System:
return T->hasMemoryOrdering() ? NVPTX::atomic_thread_fence_acquire_sys
: NVPTX::INT_MEMBAR_SYS;
case NVPTX::Scope::Block:
return T->hasMemoryOrdering() ? NVPTX::atomic_thread_fence_acquire_cta
: NVPTX::INT_MEMBAR_CTA;
case NVPTX::Scope::Cluster:
return NVPTX::atomic_thread_fence_acquire_cluster;
case NVPTX::Scope::Device:
return T->hasMemoryOrdering() ? NVPTX::atomic_thread_fence_acquire_gpu
: NVPTX::INT_MEMBAR_GL;
case NVPTX::Scope::Thread:
report_fatal_error(
formatv("Unsupported scope \"{}\" for acquire/release/acq_rel fence.",
ScopeToString(S)));
}
break;
case NVPTX::Ordering::Release:
switch (S) {
case NVPTX::Scope::System:
return T->hasMemoryOrdering() ? NVPTX::atomic_thread_fence_release_sys
: NVPTX::INT_MEMBAR_SYS;
case NVPTX::Scope::Block:
return T->hasMemoryOrdering() ? NVPTX::atomic_thread_fence_release_cta
: NVPTX::INT_MEMBAR_CTA;
case NVPTX::Scope::Cluster:
return NVPTX::atomic_thread_fence_release_cluster;
case NVPTX::Scope::Device:
return T->hasMemoryOrdering() ? NVPTX::atomic_thread_fence_release_gpu
: NVPTX::INT_MEMBAR_GL;
case NVPTX::Scope::Thread:
report_fatal_error(
formatv("Unsupported scope \"{}\" for acquire/release/acq_rel fence.",
ScopeToString(S)));
}
break;
case NVPTX::Ordering::AcquireRelease: {
switch (S) {
case NVPTX::Scope::System:
Expand Down
37 changes: 10 additions & 27 deletions llvm/lib/Target/NVPTX/NVPTXInstrInfo.td
Original file line number Diff line number Diff line change
Expand Up @@ -3866,33 +3866,16 @@ def : Pat <
// PTX Fence instructions
////////////////////////////////////////////////////////////////////////////////

def atomic_thread_fence_seq_cst_sys :
NVPTXInst<(outs), (ins), "fence.sc.sys;", []>,
Requires<[hasPTX<60>, hasSM<70>]>;
def atomic_thread_fence_acq_rel_sys :
NVPTXInst<(outs), (ins), "fence.acq_rel.sys;", []>,
Requires<[hasPTX<60>, hasSM<70>]>;

def atomic_thread_fence_seq_cst_gpu :
NVPTXInst<(outs), (ins), "fence.sc.gpu;", []>,
Requires<[hasPTX<60>, hasSM<70>]>;
def atomic_thread_fence_acq_rel_gpu :
NVPTXInst<(outs), (ins), "fence.acq_rel.gpu;", []>,
Requires<[hasPTX<60>, hasSM<70>]>;

def atomic_thread_fence_seq_cst_cluster :
NVPTXInst<(outs), (ins), "fence.sc.cluster;", []>,
Requires<[hasPTX<78>, hasSM<90>]>;
def atomic_thread_fence_acq_rel_cluster :
NVPTXInst<(outs), (ins), "fence.acq_rel.cluster;", []>,
Requires<[hasPTX<78>, hasSM<90>]>;

def atomic_thread_fence_seq_cst_cta :
NVPTXInst<(outs), (ins), "fence.sc.cta;", []>,
Requires<[hasPTX<60>, hasSM<70>]>;
def atomic_thread_fence_acq_rel_cta :
NVPTXInst<(outs), (ins), "fence.acq_rel.cta;", []>,
Requires<[hasPTX<60>, hasSM<70>]>;
class NVPTXFenceInst<string scope, string sem, Predicate ptx>:
NVPTXInst<(outs), (ins), "fence."#sem#"."#scope#";", []>,
Requires<[ptx, hasSM<70>]>;

foreach scope = ["sys", "gpu", "cluster", "cta"] in {
def atomic_thread_fence_seq_cst_#scope: NVPTXFenceInst<scope, "sc", hasPTX<60>>;
def atomic_thread_fence_acq_rel_#scope: NVPTXFenceInst<scope, "acq_rel", hasPTX<60>>;
def atomic_thread_fence_acquire_#scope: NVPTXFenceInst<scope, "acquire", hasPTX<87>>;
def atomic_thread_fence_release_#scope: NVPTXFenceInst<scope, "release", hasPTX<87>>;
}

def fpimm_any_zero : FPImmLeaf<fAny, [{
return Imm.isZero();
Expand Down
4 changes: 4 additions & 0 deletions llvm/lib/Target/NVPTX/NVPTXSubtarget.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ class NVPTXSubtarget : public NVPTXGenSubtargetInfo {
// Does SM & PTX support memory orderings (weak and atomic: relaxed, acquire,
// release, acq_rel, sc) ?
bool hasMemoryOrdering() const { return SmVersion >= 70 && PTXVersion >= 60; }
// Does SM & PTX support .acquire and .release qualifiers for fence?
bool hasSplitAcquireAndReleaseFences() const {
return SmVersion >= 90 && PTXVersion >= 86;
}
// Does SM & PTX support atomic relaxed MMIO operations ?
bool hasRelaxedMMIO() const { return SmVersion >= 70 && PTXVersion >= 82; }
bool hasDotInstructions() const {
Expand Down
55 changes: 55 additions & 0 deletions llvm/test/CodeGen/NVPTX/fence-cluster.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
; RUN: llc < %s -march=nvptx64 -mcpu=sm_90 -mattr=+ptx87 | FileCheck %s --check-prefix=SM90
; RUN: %if ptxas %{ llc < %s -march=nvptx -mcpu=sm_90 -mattr=+ptx87 | %ptxas-verify %}

define void @fence_acquire_cluster() {
; SM90-LABEL: fence_acquire_cluster(
; SM90: {
; SM90-EMPTY:
; SM90-EMPTY:
; SM90-NEXT: // %bb.0:
; SM90-NEXT: fence.acquire.cluster;
; SM90-NEXT: ret;
fence syncscope("cluster") acquire
ret void
}


define void @fence_release_cluster() {
; SM90-LABEL: fence_release_cluster(
; SM90: {
; SM90-EMPTY:
; SM90-EMPTY:
; SM90-NEXT: // %bb.0:
; SM90-NEXT: fence.release.cluster;
; SM90-NEXT: ret;
fence syncscope("cluster") release
ret void
}


define void @fence_acq_rel_cluster() {
; SM90-LABEL: fence_acq_rel_cluster(
; SM90: {
; SM90-EMPTY:
; SM90-EMPTY:
; SM90-NEXT: // %bb.0:
; SM90-NEXT: fence.acq_rel.cluster;
; SM90-NEXT: ret;
fence syncscope("cluster") acq_rel
ret void
}


define void @fence_seq_cst_cluster() {
; SM90-LABEL: fence_seq_cst_cluster(
; SM90: {
; SM90-EMPTY:
; SM90-EMPTY:
; SM90-NEXT: // %bb.0:
; SM90-NEXT: fence.sc.cluster;
; SM90-NEXT: ret;
fence syncscope("cluster") seq_cst
ret void
}

Loading