Skip to content

workflows/premerge: Enable macos builds #125176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

tstellar
Copy link
Collaborator

We still have buildkite for testing Linux and Windows, so we don't need to enable those builds yet.

We still have buildkite for testing Linux and Windows, so we don't need
to enable those builds yet.
@tstellar
Copy link
Collaborator Author

This is just for the release branch.

@tstellar tstellar added this to the LLVM 20.X Release milestone Jan 31, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 31, 2025

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

We still have buildkite for testing Linux and Windows, so we don't need to enable those builds yet.


Full diff: https://github.com/llvm/llvm-project/pull/125176.diff

1 Files Affected:

  • (modified) .github/workflows/premerge.yaml (+2-4)
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index d7fa6718821861..49ffcc0c7ddd24 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -5,8 +5,6 @@ permissions:
 
 on:
   pull_request:
-    paths:
-      - .github/workflows/premerge.yaml
   push:
     branches:
       - 'main'
@@ -14,7 +12,7 @@ on:
 
 jobs:
   premerge-checks-linux:
-    if: github.repository_owner == 'llvm'
+    if: false && github.repository_owner == 'llvm'
     runs-on: llvm-premerge-linux-runners
     concurrency:
       group: ${{ github.workflow }}-linux-${{ github.event.pull_request.number || github.sha }}
@@ -73,7 +71,7 @@ jobs:
           ./.ci/monolithic-linux.sh "$(echo ${linux_projects} | tr ' ' ';')" "$(echo ${linux_check_targets})" "$(echo ${linux_runtimes} | tr ' ' ';')" "$(echo ${linux_runtime_check_targets})"
 
   premerge-checks-windows:
-    if: github.repository_owner == 'llvm'
+    if: false && github.repository_owner == 'llvm'
     runs-on: llvm-premerge-windows-runners
     concurrency:
       group: ${{ github.workflow }}-windows-${{ github.event.pull_request.number || github.sha }}

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Eventually we will want to turn on the premerge jobs as we plan on sunsetting the Buildkite infrastructure once the new self-hosted GHA runner system is stable. I can help backport and patches that need to make it to the release branch.

@tstellar tstellar merged commit 78b5d67 into llvm:release/20.x Jan 31, 2025
9 checks passed
Copy link

@tstellar (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants