-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[MLIR][LLVM] Implement LLVM dialect support for global aliases #125295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bcardosolopes
merged 25 commits into
llvm:main
from
bcardosolopes:mlir-llvm-global-alias
Feb 6, 2025
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
cff1cd3
[MLIR][LLVM] Implement LLVM dialect support for global aliases
bcardosolopes 8ccafc9
Fix comments
bcardosolopes e36ff90
Remove undef from testcase
bcardosolopes f12825e
Address Tobias review
bcardosolopes 1186559
Add addrspace related tests
bcardosolopes 1927cb5
Reorganize tests a bit, use -split-input-file
bcardosolopes 7b27f3a
More verification love
bcardosolopes 82ca97a
Refactor common parsing bits for GlobalOp and AliasOp
bcardosolopes 8711298
Add roundtrip tests for the parsing/printing
bcardosolopes 3eb7a53
Fix more nits and align linkage verification with LLVM
bcardosolopes f159dcc
Fix one more comment
bcardosolopes cf984ad
Update parse comment
bcardosolopes 77661e7
Handle conversion for globals/aliases together since they can referen…
bcardosolopes b669463
Teach LLVM_AddressOfOp to work with alias symbols, fix remaining bugs…
bcardosolopes 644424d
Improve LLVM_AddressOfOp description doc
bcardosolopes 0d181ee
More tablegen fixes, new test file in Dialect
bcardosolopes 3932b16
Address more review comments
bcardosolopes d8bd0ab
More split-input-file love
bcardosolopes 8683355
Fix multiple printing of addressofs in init bodies
bcardosolopes d69436c
Get rid of address space as top level AliasOp attribute
bcardosolopes f0755a4
Fix test, removed too much from globals
bcardosolopes e4346f6
Add one more verifier check to addressof
bcardosolopes 334d643
address more reviews
bcardosolopes bd0b538
Remove addr_space from globals to clean it up a bit
bcardosolopes 7c293b2
Fix newline
bcardosolopes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.