Silence -Wunused-parameter warnings in Unwind-wasm.c

[georgthegreat]

No description provided.

[llvmbot]

@llvm/pr-subscribers-libunwind

Author: Yuriy Chernyshov (georgthegreat)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/125412.diff

1 Files Affected:

• (modified) libunwind/src/Unwind-wasm.c (+3-3)

diff --git a/libunwind/src/Unwind-wasm.c b/libunwind/src/Unwind-wasm.c
index b18b32c5d17847..fe016b8f5923ad 100644
--- a/libunwind/src/Unwind-wasm.c
+++ b/libunwind/src/Unwind-wasm.c
@@ -102,8 +102,8 @@ _LIBUNWIND_EXPORT uintptr_t _Unwind_GetIP(struct _Unwind_Context *context) {
 }
 
 /// Not used in Wasm.
-_LIBUNWIND_EXPORT void _Unwind_SetIP(struct _Unwind_Context *context,
-                                     uintptr_t value) {}
+_LIBUNWIND_EXPORT void _Unwind_SetIP([[maybe_unused]] struct _Unwind_Context *context,
+                                     [[maybe_unused]] uintptr_t value) {}
 
 /// Called by personality handler to get LSDA for current frame.
 _LIBUNWIND_EXPORT uintptr_t
@@ -116,7 +116,7 @@ _Unwind_GetLanguageSpecificData(struct _Unwind_Context *context) {
 
 /// Not used in Wasm.
 _LIBUNWIND_EXPORT uintptr_t
-_Unwind_GetRegionStart(struct _Unwind_Context *context) {
+_Unwind_GetRegionStart([[maybe_unused]] struct _Unwind_Context *context) {
   return 0;
 }
 

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[MaskRay]

What's your build option?

llvm-project considers this warning low value and llvm/cmake/modules/HandleLLVMOptions.cmake specifies -Wno-unused-parameter.

[georgthegreat]

@MaskRay, we build libunwind using our own build system with the clang default set of warnings enabled.

There is already a couple of [[maybe_unused]] attributes in this library, so I do not bring anything new:

(dflt) thegeorg@jakku:~/contrib/llvm/libunwind@main$ rg unused]]
src/Unwind-EHABI.cpp
890:[[gnu::unused]] static uint64_t

src/UnwindCursor.hpp
3050:  [[maybe_unused]] const int Result = syscall(

[ldionne]

IMO this is reasonable but it's simpler to drop the parameter names in this case, no need for [[maybe_unused]].

[georgthegreat]

I applied @ldionne suggestions, I am fine with his approach.

[ldionne]

I'm fine with this, but I don't want to override @MaskRay 's (dis)approval since his opinion prevails on libunwind matters. If @MaskRay doesn't raise any concerns within a few days, I think this would be reasonable to merge since it's fairly harmless.

[georgthegreat]

@ldionne, may we proceed with merging this?

[ldionne]

Sure, but I am not certain why you added some newlines though. Can you leave the formatting as it was?

[georgthegreat]

I think this is how my clang-format-16 auto-formatted it.
I have applied the formatting from the check, it is green now.