[libc][unistd] Implement setsid #125704

krishna2803 · 2025-02-04T15:38:45Z

https://man7.org/linux/man-pages/man2/setsid.2.html

github-actions · 2025-02-04T15:39:03Z

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

llvmbot · 2025-02-04T15:40:00Z

@llvm/pr-subscribers-libc

Author: Krishna Pandey (krishna2803)

Changes

https://man7.org/linux/man-pages/man2/setsid.2.html

closes #124632

Full diff: https://github.com/llvm/llvm-project/pull/125704.diff

10 Files Affected:

(modified) libc/config/linux/aarch64/entrypoints.txt (+1)
(modified) libc/config/linux/riscv/entrypoints.txt (+1)
(modified) libc/config/linux/x86_64/entrypoints.txt (+1)
(modified) libc/include/unistd.yaml (+6)
(modified) libc/src/unistd/CMakeLists.txt (+7)
(modified) libc/src/unistd/linux/CMakeLists.txt (+14)
(added) libc/src/unistd/linux/setsid.cpp (+23)
(added) libc/src/unistd/setsid.h (+22)
(modified) libc/test/src/unistd/CMakeLists.txt (+10)
(added) libc/test/src/unistd/setsid_test.cpp (+15)

diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 09eb51a3f8fc62..49e3c04b0ca16a 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -341,6 +341,7 @@ set(TARGET_LIBC_ENTRYPOINTS
     libc.src.unistd.readlink
     libc.src.unistd.readlinkat
     libc.src.unistd.rmdir
+    libc.src.unistd.setsid
     libc.src.unistd.symlink
     libc.src.unistd.symlinkat
     libc.src.unistd.sysconf
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 14a05a2f3fbf2a..4d1d87170208d0 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -337,6 +337,7 @@ set(TARGET_LIBC_ENTRYPOINTS
     libc.src.unistd.readlink
     libc.src.unistd.readlinkat
     libc.src.unistd.rmdir
+    libc.src.unistd.setsid
     libc.src.unistd.symlink
     libc.src.unistd.symlinkat
     libc.src.unistd.sysconf
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 366e4d34294d15..c8e0adaeee2827 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -340,6 +340,7 @@ set(TARGET_LIBC_ENTRYPOINTS
     libc.src.unistd.readlink
     libc.src.unistd.readlinkat
     libc.src.unistd.rmdir
+    libc.src.unistd.setsid
     libc.src.unistd.symlink
     libc.src.unistd.symlinkat
     libc.src.unistd.sysconf
diff --git a/libc/include/unistd.yaml b/libc/include/unistd.yaml
index c1901be446fe5c..d04d46bd5c002a 100644
--- a/libc/include/unistd.yaml
+++ b/libc/include/unistd.yaml
@@ -275,6 +275,12 @@ functions:
       - type: const void *__restrict
       - type: void *
       - type: ssize_t
+  - name: setsid
+    standards:
+      - POSIX
+    return_type: pid_t
+    arguments:
+      - type: void
   - name: symlink
     standards:
       - POSIX
diff --git a/libc/src/unistd/CMakeLists.txt b/libc/src/unistd/CMakeLists.txt
index 6bdea0c7693bd9..fb563ec4ecfd99 100644
--- a/libc/src/unistd/CMakeLists.txt
+++ b/libc/src/unistd/CMakeLists.txt
@@ -231,6 +231,13 @@ add_entrypoint_object(
     .${LIBC_TARGET_OS}.rmdir
 )
 
+add_entrypoint_object(
+  setsid
+  ALIAS
+  DEPENDS
+    .${LIBC_TARGET_OS}.setsid
+)
+
 add_entrypoint_object(
   symlink
   ALIAS
diff --git a/libc/src/unistd/linux/CMakeLists.txt b/libc/src/unistd/linux/CMakeLists.txt
index 2bb17f56f7b32e..88db28acbaeb90 100644
--- a/libc/src/unistd/linux/CMakeLists.txt
+++ b/libc/src/unistd/linux/CMakeLists.txt
@@ -459,6 +459,20 @@ add_entrypoint_object(
     libc.src.errno.errno
 )
 
+add_entrypoint_object(
+  setsid
+  SRCS
+    setsid.cpp
+  HDRS
+    ../setsid.h
+  DEPENDS
+    libc.hdr.types.pid_t
+    libc.hdr.fcntl_macros
+    libc.include.unistd
+    libc.include.sys_syscall
+    libc.src.__support.OSUtil.osutil
+)
+
 add_entrypoint_object(
   symlink
   SRCS
diff --git a/libc/src/unistd/linux/setsid.cpp b/libc/src/unistd/linux/setsid.cpp
new file mode 100644
index 00000000000000..9ed7307ab89829
--- /dev/null
+++ b/libc/src/unistd/linux/setsid.cpp
@@ -0,0 +1,23 @@
+//===-- Linux implementation of setsid-------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/unistd/setsid.h"
+
+#include "src/__support/OSUtil/syscall.h" // For internal syscall function.
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+
+#include <sys/syscall.h> // For syscall numbers.
+
+namespace LIBC_NAMESPACE_DECL {
+
+LLVM_LIBC_FUNCTION(pid_t, setsid, ()) {
+  return LIBC_NAMESPACE::syscall_impl<pid_t>(SYS_setsid);
+}
+
+} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/unistd/setsid.h b/libc/src/unistd/setsid.h
new file mode 100644
index 00000000000000..7f40cb84de300b
--- /dev/null
+++ b/libc/src/unistd/setsid.h
@@ -0,0 +1,22 @@
+//===-- Implementation header for setsid ------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_UNISTD_GETPID_H
+#define LLVM_LIBC_SRC_UNISTD_GETPID_H
+
+#include "hdr/types/pid_t.h"
+#include "hdr/unistd_macros.h"
+#include "src/__support/macros/config.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+pid_t setsid();
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC_UNISTD_GETPID_H
diff --git a/libc/test/src/unistd/CMakeLists.txt b/libc/test/src/unistd/CMakeLists.txt
index b01cce931a1ebf..665cb367ba4fdd 100644
--- a/libc/test/src/unistd/CMakeLists.txt
+++ b/libc/test/src/unistd/CMakeLists.txt
@@ -287,6 +287,16 @@ add_libc_unittest(
     libc.src.__support.CPP.string_view
 )
 
+add_libc_unittest(
+  setsid_test
+  SUITE
+    libc_unistd_unittests
+  SRCS
+    setsid_test.cpp
+  DEPENDS
+    libc.src.unistd.setsid
+)
+
 add_libc_unittest(
   symlink_test
   SUITE
diff --git a/libc/test/src/unistd/setsid_test.cpp b/libc/test/src/unistd/setsid_test.cpp
new file mode 100644
index 00000000000000..466faa16ea1eb6
--- /dev/null
+++ b/libc/test/src/unistd/setsid_test.cpp
@@ -0,0 +1,15 @@
+//===-- Unittests for setsid ----------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/unistd/setsid.h"
+#include "test/UnitTest/Test.h"
+
+TEST(LlvmLibcGetPidTest, SmokeTest) {
+  // setsid always succeeds. So, we just call it as a smoke test.
+  LIBC_NAMESPACE::setsid();
+}

RossComputerGuy

This looks fine to me

nickdesaulniers

Thanks for the patch. Just a few things we can trim out.

libc/src/unistd/setsid.h

libc/src/unistd/linux/setsid.cpp

libc/src/unistd/linux/CMakeLists.txt

nickdesaulniers

Thanks for the patch! Do you need us to merge this for you?

krishna2803 · 2025-02-05T17:29:43Z

yeah, that'd be great, thanks!! :D

github-actions · 2025-02-05T18:10:41Z

@krishna2803 Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

https://man7.org/linux/man-pages/man2/setsid.2.html closes llvm#124632

krishna2803 added 3 commits February 4, 2025 21:01

feat: implement setsid

62e0c25

nit: clang-format

c917d11

fix: typo change getpid to setsid

2f0d16e

llvmbot added the libc label Feb 4, 2025

RossComputerGuy approved these changes Feb 4, 2025

View reviewed changes

nickdesaulniers requested changes Feb 4, 2025

View reviewed changes

libc/src/unistd/setsid.h Outdated Show resolved Hide resolved

libc/src/unistd/linux/setsid.cpp Show resolved Hide resolved

libc/src/unistd/linux/CMakeLists.txt Outdated Show resolved Hide resolved

libc/src/unistd/linux/CMakeLists.txt Outdated Show resolved Hide resolved

nit: remove redundant includes

52a98bb

krishna2803 requested a review from nickdesaulniers February 5, 2025 11:30

nickdesaulniers approved these changes Feb 5, 2025

View reviewed changes

Merge branch 'main' into implement-setsid

44d15dc

nickdesaulniers merged commit 6f750cf into llvm:main Feb 5, 2025
12 of 13 checks passed

krishna2803 deleted the implement-setsid branch February 5, 2025 22:11

Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025

[libc][unistd] Implement setsid (llvm#125704)

412bef7

https://man7.org/linux/man-pages/man2/setsid.2.html closes llvm#124632

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[libc][unistd] Implement setsid #125704

[libc][unistd] Implement setsid #125704

Uh oh!

krishna2803 commented Feb 4, 2025

Uh oh!

github-actions bot commented Feb 4, 2025

Uh oh!

llvmbot commented Feb 4, 2025

Uh oh!

RossComputerGuy left a comment

Uh oh!

nickdesaulniers left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickdesaulniers left a comment

Uh oh!

krishna2803 commented Feb 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

Uh oh!

[libc][unistd] Implement setsid #125704

[libc][unistd] Implement setsid #125704

Uh oh!

Conversation

krishna2803 commented Feb 4, 2025

Uh oh!

github-actions bot commented Feb 4, 2025

Uh oh!

llvmbot commented Feb 4, 2025

Uh oh!

RossComputerGuy left a comment

Choose a reason for hiding this comment

Uh oh!

nickdesaulniers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickdesaulniers left a comment

Choose a reason for hiding this comment

Uh oh!

krishna2803 commented Feb 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

Uh oh!