Skip to content

[TOSA] fix TileOp description #125707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025
Merged

[TOSA] fix TileOp description #125707

merged 1 commit into from
Feb 4, 2025

Conversation

Jerry-Ge
Copy link
Member

@Jerry-Ge Jerry-Ge commented Feb 4, 2025

Simple textual fix to match TOSA v1.0 specification: https://www.mlplatform.org/tosa/tosa_spec.html#_tile

Signed-off-by: Arteen Abrishami <[email protected]>
Change-Id: I9dec76cde71dc95c5c89c7cd038668931724fc6c
@llvmbot
Copy link
Member

llvmbot commented Feb 4, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-tosa

Author: Jerry-Ge (Jerry-Ge)

Changes

Simple textual fix to match TOSA v1.0 specification: https://www.mlplatform.org/tosa/tosa_spec.html#_tile


Full diff: https://github.com/llvm/llvm-project/pull/125707.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td (+1-1)
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
index 819547855d1015b..8ede271cc56a8a9 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
@@ -1700,7 +1700,7 @@ def Tosa_TileOp : Tosa_InferShapedTypeOp<"tile"> {
   let summary = "Tile operator";
 
   let description = [{
-    Replicates input 0 multiplies times along each dimension.
+    Replicates input1 multiplies times along each dimension.
   }];
 
   let arguments = (ins

@Jerry-Ge Jerry-Ge merged commit 389d135 into llvm:main Feb 4, 2025
8 of 9 checks passed
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
Simple textual fix to match TOSA v1.0 specification:
https://www.mlplatform.org/tosa/tosa_spec.html#_tile

Signed-off-by: Arteen Abrishami <[email protected]>
Co-authored-by: Arteen Abrishami <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants