Skip to content

[clang][bytecode] Print desriptor PrimType in dump() #125726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

tbaederr
Copy link
Contributor

@tbaederr tbaederr commented Feb 4, 2025

No description provided.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Feb 4, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 4, 2025

@llvm/pr-subscribers-clang

Author: Timm Baeder (tbaederr)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/125726.diff

1 Files Affected:

  • (modified) clang/lib/AST/ByteCode/Disasm.cpp (+1-1)
diff --git a/clang/lib/AST/ByteCode/Disasm.cpp b/clang/lib/AST/ByteCode/Disasm.cpp
index 3c55c884a3507c..92a169a37c3656 100644
--- a/clang/lib/AST/ByteCode/Disasm.cpp
+++ b/clang/lib/AST/ByteCode/Disasm.cpp
@@ -240,7 +240,7 @@ LLVM_DUMP_METHOD void Descriptor::dump(llvm::raw_ostream &OS) const {
   else if (isRecord())
     OS << " record";
   else if (isPrimitive())
-    OS << " primitive";
+    OS << " primitive " << primTypeToString(getPrimType());
 
   if (isZeroSizeArray())
     OS << " zero-size-array";

Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't NFC; it's changing the output from dump. If we're not testing this dump functionality, that's fine, we don't need to add new tests. But it's not really NFC when it changes output.

@tbaederr tbaederr changed the title [clang][bytecode][NFC] Print desriptor PrimType in dump() [clang][bytecode] Print desriptor PrimType in dump() Feb 4, 2025
@tbaederr
Copy link
Contributor Author

tbaederr commented Feb 4, 2025

Hm, yeah I guess you're right, thanks. Removed the NFC.

@tbaederr tbaederr merged commit e90f9b4 into llvm:main Feb 5, 2025
11 checks passed
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants