Skip to content

[docs] Improvements to HowToAddABuilder local test guide #125802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

asb
Copy link
Contributor

@asb asb commented Feb 5, 2025

This patch makes the following improvements:

  • Corrects the suggestion that bbenv needs to be made within an llvm-zorg checkout.
  • Gives workarounds for following the instructions on a system with Python 3.13 (it removed some long-deprecated libraries, which causes problems).
  • Adds a note about how some builder workflows involve checking out llvm-zorg to retrieve additional scripts and gives guidance on how you can still make and test local changes to those scripts when that's the case.

This patch makes the following improvements:
* Corrects the suggestion that `bbenv` needs to be made within an
  llvm-zorg checkout.
* Gives workarounds for following the instructions on a system with
  Python 3.13 (it removed some long-deprecated libraries, which causes
  problems).
* Adds a note about how some builder workflows involve checking out
  llvm-zorg to retrieve additional scripts and gives guidance on how you
  can still make and test local changes to those scripts when that's the
  case.
Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asb asb merged commit 96d46c6 into llvm:main Feb 5, 2025
6 of 7 checks passed
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
This patch makes the following improvements:
* Corrects the suggestion that `bbenv` needs to be made within an
llvm-zorg checkout.
* Gives workarounds for following the instructions on a system with
Python 3.13 (it removed some long-deprecated libraries, which causes
problems).
* Adds a note about how some builder workflows involve checking out
llvm-zorg to retrieve additional scripts and gives guidance on how you
can still make and test local changes to those scripts when that's the
case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants