[TableGen] Add declarations to silence gcc warning. NFC #125892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add declarations of SDTypeConstraint's operator== and operator< to the llvm namespace. These are declared as friends inside the class which makes them part of the enclosing namespace, but gcc wants it to be more explicit. Fixes llvm#125537.
|
@llvm/pr-subscribers-tablegen Author: Craig Topper (topperc) ChangesAdd declarations of SDTypeConstraint's operator== and operator< to the llvm namespace. These are declared as friends inside the class which makes them part of the enclosing namespace, but gcc wants it to be more explicit. Fixes #125537. Full diff: https://github.com/llvm/llvm-project/pull/125892.diff 1 Files Affected:
diff --git a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h
index 6a6f1a6ac437cc..328700cd0d163a 100644
--- a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h
+++ b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.h
@@ -393,6 +393,9 @@ struct SDTypeConstraint {
const SDTypeConstraint &RHS);
};
+bool operator==(const SDTypeConstraint &LHS, const SDTypeConstraint &RHS);
+bool operator<(const SDTypeConstraint &LHS, const SDTypeConstraint &RHS);
+
/// ScopedName - A name of a node associated with a "scope" that indicates
/// the context (e.g. instance of Pattern or PatFrag) in which the name was
/// used. This enables substitution of pattern fragments while keeping track
|
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
Add declarations of SDTypeConstraint's operator== and operator< to the llvm namespace. These are declared as friends inside the class which makes them part of the enclosing namespace, but gcc wants it to be more explicit. Fixes llvm#125537.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add declarations of SDTypeConstraint's operator== and operator< to the llvm namespace. These are declared as friends inside the class which makes them part of the enclosing namespace, but gcc wants it to be more explicit.
Fixes #125537.