Skip to content

[mlir][LLVM][NFC] Fix description of LLVMFixedVectorType #126031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

matthias-springer
Copy link
Member

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Feb 6, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-llvm

Author: Matthias Springer (matthias-springer)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/126031.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.td (+3-3)
diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.td
index 77c8035ce3d71a3..0b9e4b9c5573839 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.td
@@ -291,9 +291,9 @@ def LLVMPointerType : LLVMType<"LLVMPointer", "ptr", [
 def LLVMFixedVectorType : LLVMType<"LLVMFixedVector", "vec"> {
   let summary = "LLVM fixed vector type";
   let description = [{
-    LLVM dialect scalable vector type, represents a sequence of elements of
-    unknown length that is known to be divisible by some constant. These
-    elements can be processed as one in SIMD context.
+    LLVM dialect vector type that supports all element types that are supported
+    in LLVM vectors but that are not supported by the builtin MLIR vector type.
+    E.g., LLVMFixedVectorType supports LLVM pointers as element type.
   }];
 
   let typeName = "llvm.fixed_vec";

Copy link
Contributor

@gysit gysit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM

@matthias-springer matthias-springer merged commit 8c2b4aa into main Feb 6, 2025
8 of 10 checks passed
@matthias-springer matthias-springer deleted the users/matthias-springer/llvm_vec_docs branch February 6, 2025 09:37
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants