[analyzer][NFC] Remove "V2" from ArrayBoundCheckerV2.cpp #126094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously commit 6e17ed9 deleted the obsolete checker `alpha.security.ArrayBound` which was implemented in `ArrayBoundChecker.cpp` and renamed the checker `alpha.security.ArrayBoundV2` to `security.ArrayBound`. This commit concludes that consolidation by renaming the source file `ArrayBoundCheckerV2.cpp` to `ArrayBoundChecker.cpp` (which was "freed up" by the previous commit).
llvmbot
added
clang
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: Donát Nagy (NagyDonat) ChangesPreviously commit 6e17ed9 deleted the obsolete checker This commit concludes that consolidation by renaming the source file Full diff: https://github.com/llvm/llvm-project/pull/126094.diff 3 Files Affected:
diff --git a/clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp b/clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp
similarity index 98%
rename from clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp
rename to clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp
index 6f8d6dbd573f403..4c582f7bcf8c5c4 100644
--- a/clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp
@@ -1,4 +1,4 @@
-//== ArrayBoundCheckerV2.cpp ------------------------------------*- C++ -*--==//
+//== ArrayBoundChecker.cpp --------------------------------------*- C++ -*--==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
@@ -11,12 +11,6 @@
//
//===----------------------------------------------------------------------===//
-// NOTE: The name of this file ends with "V2" because previously
-// "ArrayBoundChecker.cpp" contained the implementation of another (older and
-// simpler) checker that was called `alpha.security.ArrayBound`.
-// TODO: Rename this file to "ArrayBoundChecker.cpp" when it won't be confused
-// with that older file.
-
#include "clang/AST/CharUnits.h"
#include "clang/AST/ParentMapContext.h"
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
diff --git a/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt b/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt
index ccff5d0ac3b9649..591004344098781 100644
--- a/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt
+++ b/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt
@@ -7,7 +7,7 @@ set(LLVM_LINK_COMPONENTS
add_clang_library(clangStaticAnalyzerCheckers
AnalysisOrderChecker.cpp
AnalyzerStatsChecker.cpp
- ArrayBoundCheckerV2.cpp
+ ArrayBoundChecker.cpp
BasicObjCFoundationChecks.cpp
BitwiseShiftChecker.cpp
BlockInCriticalSectionChecker.cpp
diff --git a/llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gn b/llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gn
index c1bba99be3ba5c3..d9c32575366399b 100644
--- a/llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gn
+++ b/llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gn
@@ -16,7 +16,7 @@ static_library("Checkers") {
sources = [
"AnalysisOrderChecker.cpp",
"AnalyzerStatsChecker.cpp",
- "ArrayBoundCheckerV2.cpp",
+ "ArrayBoundChecker.cpp",
"BasicObjCFoundationChecks.cpp",
"BitwiseShiftChecker.cpp",
"BlockInCriticalSectionChecker.cpp",
|
|
This change is very trivial, but I'm opening a review for it because I'm not sure what's the ideal time for merging this. I' think putting this into a separate commit is already sufficient to prevent any confusion between the old contents of Does anybody know a reason for delaying this change? |
steakhal
reviewed
Feb 6, 2025
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Co-authored-by: Balazs Benics <[email protected]>
steakhal
approved these changes
Feb 7, 2025
I searched for
|
Xazax-hun
approved these changes
Feb 7, 2025
|
I verified that |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/22419 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/12966 Here is the relevant piece of the build log for the reference |
|
I checked the buildbot reports and they are irrelevant timeouts in completely unrelated parts of the testsuite. |
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
Previously commit 6e17ed9 deleted the obsolete checker `alpha.security.ArrayBound` which was implemented in `ArrayBoundChecker.cpp` and renamed the checker `alpha.security.ArrayBoundV2` to `security.ArrayBound`. This commit concludes that consolidation by renaming the source file `ArrayBoundCheckerV2.cpp` to `ArrayBoundChecker.cpp` (which was "freed up" by the previous commit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously commit 6e17ed9 deleted the obsolete checker
alpha.security.ArrayBoundwhich was implemented inArrayBoundChecker.cppand renamed the checkeralpha.security.ArrayBoundV2tosecurity.ArrayBound.This commit concludes that consolidation by renaming the source file
ArrayBoundCheckerV2.cpptoArrayBoundChecker.cpp(which was "freed up" by the previous commit).