[Clang] Only allow clang arguments to -Xarch

[jhuber6]

Summary:
Currently the -Xarch argument needs to re-parse the option, which goes
through every single registered argument. This causes errors when trying
to pass -O1 through it because it thinks it's a DXC option. This patch
changes the behavior to only allow clang options. Concievably we could
detect the driver mode to make this more robust, but I don't know if
there are other users for this.

Fixes: #110325

[llvmbot]

@llvm/pr-subscribers-clang

Author: Joseph Huber (jhuber6)

Changes

Summary:
Currently the -Xarch argument needs to re-parse the option, which goes
through every single registered argument. This causes errors when trying
to pass -O1 through it because it thinks it's a DXC option. This patch
changes the behavior to only allow clang options. Concievably we could
detect the driver mode to make this more robust, but I don't know if
there are other users for this.

Fixes: #110325

---

Full diff: https://github.com/llvm/llvm-project/pull/126101.diff

1 Files Affected:

• (modified) clang/lib/Driver/ToolChain.cpp (+2-1)

diff --git a/clang/lib/Driver/ToolChain.cpp b/clang/lib/Driver/ToolChain.cpp
index c25d1b6be14b50..56bc500da66b9f 100644
--- a/clang/lib/Driver/ToolChain.cpp
+++ b/clang/lib/Driver/ToolChain.cpp
@@ -1651,7 +1651,8 @@ void ToolChain::TranslateXarchArgs(
   const InputArgList &BaseArgs = Args.getBaseArgs();
   unsigned Index = BaseArgs.MakeIndex(A->getValue(ValuePos));
   unsigned Prev = Index;
-  std::unique_ptr<llvm::opt::Arg> XarchArg(Opts.ParseOneArg(Args, Index));
+  std::unique_ptr<llvm::opt::Arg> XarchArg(Opts.ParseOneArg(
+      Args, Index, llvm::opt::Visibility(clang::driver::options::ClangOption)));
 
   // If the argument parsing failed or more than one argument was
   // consumed, the -Xarch_ argument's parameter tried to consume

[llvmbot]

@llvm/pr-subscribers-clang-driver

Author: Joseph Huber (jhuber6)

Changes

Summary:
Currently the -Xarch argument needs to re-parse the option, which goes
through every single registered argument. This causes errors when trying
to pass -O1 through it because it thinks it's a DXC option. This patch
changes the behavior to only allow clang options. Concievably we could
detect the driver mode to make this more robust, but I don't know if
there are other users for this.

Fixes: #110325

---

Full diff: https://github.com/llvm/llvm-project/pull/126101.diff

1 Files Affected:

• (modified) clang/lib/Driver/ToolChain.cpp (+2-1)

diff --git a/clang/lib/Driver/ToolChain.cpp b/clang/lib/Driver/ToolChain.cpp
index c25d1b6be14b50..56bc500da66b9f 100644
--- a/clang/lib/Driver/ToolChain.cpp
+++ b/clang/lib/Driver/ToolChain.cpp
@@ -1651,7 +1651,8 @@ void ToolChain::TranslateXarchArgs(
   const InputArgList &BaseArgs = Args.getBaseArgs();
   unsigned Index = BaseArgs.MakeIndex(A->getValue(ValuePos));
   unsigned Prev = Index;
-  std::unique_ptr<llvm::opt::Arg> XarchArg(Opts.ParseOneArg(Args, Index));
+  std::unique_ptr<llvm::opt::Arg> XarchArg(Opts.ParseOneArg(
+      Args, Index, llvm::opt::Visibility(clang::driver::options::ClangOption)));
 
   // If the argument parsing failed or more than one argument was
   // consumed, the -Xarch_ argument's parameter tried to consume