Skip to content

[clang-linker-wrapper][lit] Temporarily disable OpenMP SPIR-V ELF test #126104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

sarnex
Copy link
Member

@sarnex sarnex commented Feb 6, 2025

The fix requires more investigation, and it's a test issue so reverting the product changes should not be necessary.

@sarnex sarnex marked this pull request as ready for review February 6, 2025 18:28
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Feb 6, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 6, 2025

@llvm/pr-subscribers-clang

Author: Nick Sarnie (sarnex)

Changes

The fix requires more investigation, and it's a test issue so reverting the product changes should not be necessary.


Full diff: https://github.com/llvm/llvm-project/pull/126104.diff

1 Files Affected:

  • (modified) clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp (+2)
diff --git a/clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp b/clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp
index 4f8658064e857d0..50457f47868a028 100644
--- a/clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp
+++ b/clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp
@@ -1,4 +1,6 @@
 // Verify the ELF packaging of OpenMP SPIR-V device images.
+// FIXME: Re-enable when spirv-tools feature detection fixed
+// UNSUPPORTED: system-linux
 // REQUIRES: system-linux
 // REQUIRES: spirv-tools
 // RUN: mkdir -p %t_tmp

@sarnex
Copy link
Member Author

sarnex commented Feb 6, 2025

Merging this now to unbreak CI, will address any feedback in followup

@sarnex sarnex merged commit a183184 into llvm:main Feb 6, 2025
10 of 11 checks passed
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
llvm#126104)

The fix requires more investigation, and it's a test issue so reverting
the product changes should not be necessary.

Signed-off-by: Sarnie, Nick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants