Skip to content

[flang] Activating tests added earlier #126110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Renaud-K
Copy link
Contributor

@Renaud-K Renaud-K commented Feb 6, 2025

Activating the tests added in #125917

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Feb 6, 2025
Copy link
Collaborator

@jdenny-ornl jdenny-ornl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the tests weren't actually deactivated.

@Renaud-K
Copy link
Contributor Author

Renaud-K commented Feb 6, 2025

Then, in that case we do need this change. We can keep the comments if they do not comment out the tests.

@Renaud-K Renaud-K closed this Feb 6, 2025
@jdenny-ornl
Copy link
Collaborator

Up to you. Without the context of the PR discussion, they look like meaningless typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants