Skip to content

[OpenMP] Fix misspelled symbol name #126120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[OpenMP] Fix misspelled symbol name #126120

merged 1 commit into from
Feb 6, 2025

Conversation

jhuber6
Copy link
Contributor

@jhuber6 jhuber6 commented Feb 6, 2025

Summary:
This is supposed to be __llvm_rpc_client but I screwed it up and
didn't notice at the time. Will need to be backported.

Summary:
This is supposed to be `__llvm_rpc_client` but I screwed it up and
didn't notice at the time. Will need to be backported.
@llvmbot
Copy link
Member

llvmbot commented Feb 6, 2025

@llvm/pr-subscribers-llvm-transforms

Author: Joseph Huber (jhuber6)

Changes

Summary:
This is supposed to be __llvm_rpc_client but I screwed it up and
didn't notice at the time. Will need to be backported.


Full diff: https://github.com/llvm/llvm-project/pull/126120.diff

1 Files Affected:

  • (modified) llvm/lib/Transforms/IPO/Internalize.cpp (+1-1)
diff --git a/llvm/lib/Transforms/IPO/Internalize.cpp b/llvm/lib/Transforms/IPO/Internalize.cpp
index f0270600aa2663..404102eef89fc2 100644
--- a/llvm/lib/Transforms/IPO/Internalize.cpp
+++ b/llvm/lib/Transforms/IPO/Internalize.cpp
@@ -235,7 +235,7 @@ bool InternalizePass::internalizeModule(Module &M) {
 
   // Preserve the RPC interface for GPU host callbacks when internalizing.
   if (Triple(M.getTargetTriple()).isNVPTX())
-    AlwaysPreserved.insert("__llvm_rpc_server");
+    AlwaysPreserved.insert("__llvm_rpc_client");
 
   // Mark all functions not in the api as internal.
   IsWasm = Triple(M.getTargetTriple()).isOSBinFormatWasm();

Copy link
Member

@jdoerfert jdoerfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jhuber6 jhuber6 merged commit b357495 into llvm:main Feb 6, 2025
7 of 9 checks passed
@jhuber6 jhuber6 added this to the LLVM 20.X Release milestone Feb 6, 2025
@jhuber6
Copy link
Contributor Author

jhuber6 commented Feb 6, 2025

/cherry-pick b357495

@llvmbot
Copy link
Member

llvmbot commented Feb 6, 2025

/pull-request #126121

Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
Summary:
This is supposed to be `__llvm_rpc_client` but I screwed it up and
didn't notice at the time. Will need to be backported.
swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request Feb 25, 2025
Summary:
This is supposed to be `__llvm_rpc_client` but I screwed it up and
didn't notice at the time. Will need to be backported.

(cherry picked from commit b357495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants