Skip to content

[MLIR] Add move constructor to BytecodeWriterConfig #126130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025
Merged

[MLIR] Add move constructor to BytecodeWriterConfig #126130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ceea68
[MLIR] Add move constructor to BytecodeWriterConfig
karimnosseir Feb 6, 2025
8ddbcb5
Merge branch 'main' into bytecodewriter_config_move
karimnosseir Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mlir/include/mlir/Bytecode/BytecodeWriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ class BytecodeWriterConfig {
/// printers for the fallback resources within the map.
BytecodeWriterConfig(FallbackAsmResourceMap &map,
StringRef producer = "MLIR" LLVM_VERSION_STRING);
BytecodeWriterConfig(BytecodeWriterConfig &&);
~BytecodeWriterConfig();

/// An internal implementation class that contains the state of the
Expand Down
3 changes: 3 additions & 0 deletions mlir/lib/Bytecode/Writer/BytecodeWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ BytecodeWriterConfig::BytecodeWriterConfig(FallbackAsmResourceMap &map,
: BytecodeWriterConfig(producer) {
attachFallbackResourcePrinter(map);
}
BytecodeWriterConfig::BytecodeWriterConfig(BytecodeWriterConfig &&config)
: impl(std::move(config.impl)) {}

BytecodeWriterConfig::~BytecodeWriterConfig() = default;

ArrayRef<std::unique_ptr<AttrTypeBytecodeWriter<Attribute>>>
Expand Down