Skip to content

[lldb][NFC] Remove old skipIfOutOfTreeDebugserver's #126144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ def test_fp_register_write(self):
# "register read fstat" always return 0xffff
@expectedFailureAndroid(archs=["i386"])
@skipIf(archs=no_match(["amd64", "i386", "x86_64"]))
@skipIfOutOfTreeDebugserver
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr37995")
def test_fp_special_purpose_register_read(self):
"""Test commands that read fpu special purpose registers."""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
class UnalignedWatchpointTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True

@skipIfOutOfTreeDebugserver
def test_unaligned_watchpoint(self):
"""Test an unaligned watchpoint triggered by a larger aligned write."""
self.build()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,12 @@ class HardwareBreakpointMultiThreadTestCase(HardwareBreakpointTestBase):
def does_not_support_hw_breakpoints(self):
return not super().supports_hw_breakpoints()

@skipIfOutOfTreeDebugserver
@skipTestIfFn(does_not_support_hw_breakpoints)
def test_hw_break_set_delete_multi_thread_macos(self):
self.build()
self.setTearDownCleanup()
self.break_multi_thread("delete")

@skipIfOutOfTreeDebugserver
@skipTestIfFn(does_not_support_hw_breakpoints)
def test_hw_break_set_disable_multi_thread_macos(self):
self.build()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ def get_module_with_name(self, target, name):
return None

@skipUnlessDarwin
@skipIfOutOfTreeDebugserver
@skipIfRemote
@skipIfAsan # On ASAN builds, this test times-out (rdar://98678134)
@skipIfDarwin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
class ConcurrentManyBreakpoints(ConcurrentEventsBase):
# Atomic sequences are not supported yet for MIPS in LLDB.
@skipIf(triple="^mips")
@skipIfOutOfTreeDebugserver
@expectedFailureAll(
archs=["aarch64"], oslist=["freebsd"], bugnumber="llvm.org/pr49433"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
class ConcurrentManyCrash(ConcurrentEventsBase):
# Atomic sequences are not supported yet for MIPS in LLDB.
@skipIf(triple="^mips")
@skipIfOutOfTreeDebugserver
def test(self):
"""Test 100 threads that cause a segfault."""
self.build()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ class ConcurrentManySignals(ConcurrentEventsBase):
# This test is flaky on Darwin.
@skipIfDarwin
@expectedFailureNetBSD
@skipIfOutOfTreeDebugserver
def test(self):
"""Test 100 signals from 100 threads."""
self.build()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class ConcurrentManyWatchpoints(ConcurrentEventsBase):
# Atomic sequences are not supported yet for MIPS in LLDB.
@skipIf(triple="^mips")
@add_test_categories(["watchpoint"])
@skipIfOutOfTreeDebugserver
def test(self):
"""Test 100 watchpoints from 100 threads."""
self.build()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def continue_and_report_stop_reason(self, process, iter_str):

# debugserver only gained the ability to watch larger regions
# with this patch.
@skipIfOutOfTreeDebugserver
def test_large_watchpoint(self):
"""Test watchpoint that covers a large region of memory."""
self.build()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ def hit_watchpoint_and_continue(self, process, iter_str):
# older debugservers will return the base address of the doubleword
# which lldb doesn't understand, and will stop executing without a
# proper stop reason.
@skipIfOutOfTreeDebugserver
def test_unaligned_watchpoint(self):
"""Test a watchpoint that is handled by two hardware watchpoint registers."""
self.build()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@


class TestCorefileExceptionReason(TestBase):
@skipIfOutOfTreeDebugserver # newer debugserver required for these qMemoryRegionInfo types
@no_debug_info_test
@skipUnlessDarwin
@skipIf(archs=no_match(["arm64", "arm64e"]))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
class TestCase(TestBase):
@no_debug_info_test
@skipUnlessDarwin
@skipIfOutOfTreeDebugserver
def test_abort(self):
self.build()
target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ class TestEarlyProcessLaunch(TestBase):

@skipUnlessDarwin
@skipIfAsan # rdar://103359354
@skipIfOutOfTreeDebugserver # 2022-12-13 FIXME: skipping system debugserver
# until this feature is included in the system
# debugserver.
@add_test_categories(["pyapi"])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
class TestDarwinSignalHandlers(TestBase):
NO_DEBUG_INFO_TESTCASE = True

@skipIfOutOfTreeDebugserver
@skipUnlessDarwin
def test_ignored_thread(self):
"""It isn't possible to convert an EXC_BAD_ACCESS to a signal when
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class TestDetachVrsProfile(TestBase):
NO_DEBUG_INFO_TESTCASE = True

@skipUnlessDarwin
@skipIfOutOfTreeDebugserver
@skipIfRemote
def test_profile_and_detach(self):
"""There can be many tests in a test case - describe this test here."""
Expand Down
12 changes: 0 additions & 12 deletions lldb/test/API/macosx/simulator/TestSimulatorPlatform.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ def run_with(self, arch, os, vers, env, expected_load_command):
@skipUnlessDarwin
@skipIfDarwinEmbedded
@apple_simulator_test("iphone")
@skipIfOutOfTreeDebugserver
def test_ios(self):
"""Test running an iOS simulator binary"""
self.run_with(
Expand All @@ -94,7 +93,6 @@ def test_ios(self):
@skipUnlessDarwin
@skipIfDarwinEmbedded
@apple_simulator_test("appletv")
@skipIfOutOfTreeDebugserver
def test_tvos(self):
"""Test running an tvOS simulator binary"""
self.run_with(
Expand All @@ -111,7 +109,6 @@ def test_tvos(self):
@apple_simulator_test("watch")
@skipIfDarwin # rdar://problem/64552748
@skipIf(archs=["arm64", "arm64e"])
@skipIfOutOfTreeDebugserver
def test_watchos_i386(self):
"""Test running a 32-bit watchOS simulator binary"""
self.run_with(
Expand All @@ -128,7 +125,6 @@ def test_watchos_i386(self):
@apple_simulator_test("watch")
@skipIfDarwin # rdar://problem/64552748
@skipIf(archs=["i386", "x86_64"])
@skipIfOutOfTreeDebugserver
def test_watchos_armv7k(self):
"""Test running a 32-bit watchOS simulator binary"""
self.run_with(
Expand All @@ -150,7 +146,6 @@ def test_watchos_armv7k(self):

@skipUnlessDarwin
@skipIfDarwinEmbedded
@skipIfOutOfTreeDebugserver
def test_lc_version_min_macosx(self):
"""Test running a back-deploying non-simulator MacOS X binary"""
self.run_with(
Expand All @@ -166,7 +161,6 @@ def test_lc_version_min_macosx(self):
@skipIfDarwinEmbedded
@apple_simulator_test("iphone")
@skipIf(archs=["arm64", "arm64e"])
@skipIfOutOfTreeDebugserver
def test_lc_version_min_iphoneos(self):
"""Test running a back-deploying iOS simulator binary
with a legacy iOS load command"""
Expand All @@ -183,7 +177,6 @@ def test_lc_version_min_iphoneos(self):
@skipIfDarwinEmbedded
@apple_simulator_test("iphone")
@skipIf(archs=["arm64", "arm64e"])
@skipIfOutOfTreeDebugserver
def test_ios_backdeploy_x86(self):
"""Test running a back-deploying iOS simulator binary
with a legacy iOS load command"""
Expand All @@ -200,7 +193,6 @@ def test_ios_backdeploy_x86(self):
@skipIfDarwinEmbedded
@apple_simulator_test("iphone")
@skipIf(archs=["i386", "x86_64"])
@skipIfOutOfTreeDebugserver
def test_ios_backdeploy_apple_silicon(self):
"""Test running a back-deploying iOS simulator binary"""
self.run_with(
Expand All @@ -216,7 +208,6 @@ def test_ios_backdeploy_apple_silicon(self):
@skipIfDarwinEmbedded
@apple_simulator_test("appletv")
@skipIf(archs=["arm64", "arm64e"])
@skipIfOutOfTreeDebugserver
def test_lc_version_min_tvos(self):
"""Test running a back-deploying tvOS simulator binary
with a legacy tvOS load command"""
Expand All @@ -233,7 +224,6 @@ def test_lc_version_min_tvos(self):
@skipIfDarwinEmbedded
@apple_simulator_test("appletv")
@skipIf(archs=["i386", "x86_64"])
@skipIfOutOfTreeDebugserver
def test_tvos_backdeploy_apple_silicon(self):
"""Test running a back-deploying tvOS simulator binary"""
self.run_with(
Expand All @@ -250,7 +240,6 @@ def test_tvos_backdeploy_apple_silicon(self):
@apple_simulator_test("watch")
@skipIf(archs=["arm64", "arm64e"])
@skipIfDarwin # rdar://problem/64552748
@skipIfOutOfTreeDebugserver
def test_lc_version_min_watchos(self):
"""Test running a back-deploying watchOS simulator binary
with a legacy watchOS load command"""
Expand All @@ -268,7 +257,6 @@ def test_lc_version_min_watchos(self):
@apple_simulator_test("watch")
@skipIf(archs=["arm64", "arm64e"])
@skipIfDarwin # rdar://problem/64552748
@skipIfOutOfTreeDebugserver
def test_watchos_backdeploy_apple_silicon(self):
"""Test running a back-deploying watchOS simulator binary"""
self.run_with(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@


class TestSkinnyCorefile(TestBase):
@skipIfOutOfTreeDebugserver # newer debugserver required for these qMemoryRegionInfo types
@skipIf(
debug_info=no_match(["dsym"]),
bugnumber="This test is looking explicitly for a dSYM",
Expand Down
1 change: 0 additions & 1 deletion lldb/test/API/macosx/stack-corefile/TestStackCorefile.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@


class TestStackCorefile(TestBase):
@skipIfOutOfTreeDebugserver # newer debugserver required for these qMemoryRegionInfo types
@no_debug_info_test
@skipUnlessDarwin
@skipIfRemote
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
class TestUnregisteredMacho(TestBase):
# newer debugserver required for jGetLoadedDynamicLibrariesInfos
# to support this
@skipIfOutOfTreeDebugserver
@no_debug_info_test
@skipUnlessDarwin
def test(self):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def _extract_register_value(reg_info, reg_bank, byte_order, bytes_per_entry=8):


class TestGdbRemoteGPacket(gdbremote_testcase.GdbRemoteTestCaseBase):
@skipIfOutOfTreeDebugserver
@skipUnlessDarwin # G packet not supported
def test_g_packet(self):
self.build()
Expand Down