[Fuchsia] Disable building runtimes with LTO #126306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: Paul Kirth (ilovepi) ChangesTemporarily disable LTO'd runtimes, while we investigate an issue Full diff: https://github.com/llvm/llvm-project/pull/126306.diff 1 Files Affected:
diff --git a/clang/cmake/caches/Fuchsia-stage2.cmake b/clang/cmake/caches/Fuchsia-stage2.cmake
index ba1bb3573311456..99890b8246ad74a 100644
--- a/clang/cmake/caches/Fuchsia-stage2.cmake
+++ b/clang/cmake/caches/Fuchsia-stage2.cmake
@@ -190,8 +190,8 @@ foreach(target aarch64-unknown-linux-gnu;armv7-unknown-linux-gnueabihf;i386-unkn
set(RUNTIMES_${target}_LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi;libunwind" CACHE STRING "")
# Enable FatLTO for Linux and baremetal runtimes
- set(RUNTIMES_${target}_LLVM_ENABLE_LTO ON CACHE BOOL "")
- set(RUNTIMES_${target}_LLVM_ENABLE_FATLTO ON CACHE BOOL "")
+ set(RUNTIMES_${target}_LLVM_ENABLE_LTO OFF CACHE BOOL "")
+ set(RUNTIMES_${target}_LLVM_ENABLE_FATLTO OFF CACHE BOOL "")
# Use .build-id link.
list(APPEND RUNTIME_BUILD_ID_LINK "${target}")
@@ -276,8 +276,8 @@ if(FUCHSIA_SDK)
set(RUNTIMES_${target}+asan+noexcept_LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
# Enable FatLTO for Fuchsia runtimes
- set(RUNTIMES_${target}_LLVM_ENABLE_LTO ON CACHE BOOL "")
- set(RUNTIMES_${target}_LLVM_ENABLE_FATLTO ON CACHE BOOL "")
+ set(RUNTIMES_${target}_LLVM_ENABLE_LTO OFF CACHE BOOL "")
+ set(RUNTIMES_${target}_LLVM_ENABLE_FATLTO OFF CACHE BOOL "")
# Use .build-id link.
list(APPEND RUNTIME_BUILD_ID_LINK "${target}")
@@ -378,8 +378,8 @@ foreach(target armv6m-none-eabi;armv7m-none-eabi;armv7em-none-eabi;armv8m.main-n
set(RUNTIMES_${target}_LLVM_ENABLE_RUNTIMES "libc;libcxx" CACHE STRING "")
# Enable FatLTO for baremetal runtimes
- set(RUNTIMES_${target}_LLVM_ENABLE_LTO ON CACHE BOOL "")
- set(RUNTIMES_${target}_LLVM_ENABLE_FATLTO ON CACHE BOOL "")
+ set(RUNTIMES_${target}_LLVM_ENABLE_LTO OFF CACHE BOOL "")
+ set(RUNTIMES_${target}_LLVM_ENABLE_FATLTO OFF CACHE BOOL "")
endforeach()
foreach(target riscv32-unknown-elf)
@@ -433,8 +433,8 @@ foreach(target riscv32-unknown-elf)
set(RUNTIMES_${target}_LLVM_ENABLE_RUNTIMES "libc;libcxx" CACHE STRING "")
# Enable FatLTO for baremetal runtimes
- set(RUNTIMES_${target}_LLVM_ENABLE_LTO ON CACHE BOOL "")
- set(RUNTIMES_${target}_LLVM_ENABLE_FATLTO ON CACHE BOOL "")
+ set(RUNTIMES_${target}_LLVM_ENABLE_LTO OFF CACHE BOOL "")
+ set(RUNTIMES_${target}_LLVM_ENABLE_FATLTO OFF CACHE BOOL "")
endforeach()
set(LLVM_BUILTIN_TARGETS "${BUILTIN_TARGETS}" CACHE STRING "")
|
Temporarily disable LTO'd runtimes, while we investigate an issue building Fuchsia with LTO.
ilovepi
force-pushed
the
users/ilovepi/disable_lto_runtimes
branch
from
e74084d to
996088f
Compare
petrhosek
approved these changes
Feb 10, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/12994 Here is the relevant piece of the build log for the reference |
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
Temporarily disable LTO'd runtimes, while we investigate an issue building Fuchsia with LTO.
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
Temporarily disable LTO'd runtimes, while we investigate an issue building Fuchsia with LTO.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
Temporarily disable LTO'd runtimes, while we investigate an issue building Fuchsia with LTO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily disable LTO'd runtimes, while we investigate an issue
building Fuchsia with LTO.