[libc] Exercise all CMake build types in GitHub Action workflows

[petrhosek]

We want to test libc in all build configurations: Debug, Release and MinSizeRel which correspond to -O0, -O3 and -Os optimization flags.

[llvmbot]

@llvm/pr-subscribers-github-workflow

@llvm/pr-subscribers-libc

Author: Petr Hosek (petrhosek)

Changes

We want to test libc in all build configurations: Debug, Release and MinSizeRel which correspond to -O0, -O3 and -Os optimization flags.

---

Full diff: https://github.com/llvm/llvm-project/pull/126315.diff

2 Files Affected:

• (modified) .github/workflows/libc-fullbuild-tests.yml (+2-1)
• (modified) .github/workflows/libc-overlay-tests.yml (+2-1)

diff --git a/.github/workflows/libc-fullbuild-tests.yml b/.github/workflows/libc-fullbuild-tests.yml
index 2c88da653aae4a8..d93ac841162404b 100644
--- a/.github/workflows/libc-fullbuild-tests.yml
+++ b/.github/workflows/libc-fullbuild-tests.yml
@@ -15,6 +15,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
+        build_type: [Debug, Release, MinSizeRel]
         include:
           - os: ubuntu-24.04
             ccache-variant: sccache
@@ -68,7 +69,7 @@ jobs:
         cmake -B ${{ steps.strings.outputs.build-output-dir }}
         -DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }}
         -DCMAKE_C_COMPILER=${{ matrix.c_compiler }}
-        -DCMAKE_BUILD_TYPE=MinSizeRel
+        -DCMAKE_BUILD_TYPE=${{ matrix.build_type }}
         -DCMAKE_C_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
         -DCMAKE_CXX_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
         -DCMAKE_INSTALL_PREFIX=${{ steps.strings.outputs.build-install-dir }}
diff --git a/.github/workflows/libc-overlay-tests.yml b/.github/workflows/libc-overlay-tests.yml
index 0a0916084b18c15..de4b58c008ee48e 100644
--- a/.github/workflows/libc-overlay-tests.yml
+++ b/.github/workflows/libc-overlay-tests.yml
@@ -16,6 +16,7 @@ jobs:
       # Set fail-fast to false to ensure that feedback is delivered for all matrix combinations.
       fail-fast: false
       matrix:
+        build_type: [Debug, Release, MinSizeRel]
         include:
           # TODO: add linux gcc when it is fixed
           - os: ubuntu-24.04
@@ -95,7 +96,7 @@ jobs:
         cmake -B ${{ steps.strings.outputs.build-output-dir }}
         -DCMAKE_CXX_COMPILER=${{ matrix.compiler.cpp_compiler }}
         -DCMAKE_C_COMPILER=${{ matrix.compiler.c_compiler }}
-        -DCMAKE_BUILD_TYPE=MinSizeRel
+        -DCMAKE_BUILD_TYPE=${{ matrix.build_type }}
         -DCMAKE_C_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
         -DCMAKE_CXX_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
         -DCMAKE_POLICY_DEFAULT_CMP0141=NEW

[nickdesaulniers]

thanks for the patch!

[boomanaiden154]

This should be fine, but we do need to be careful that we don't exceed the Github actions queue and make actions related to other workflows wait. I don't think this will be an issue given the release tests are done on Buildkite (migrating to GHA soonish on self hosted runners) and that they're pretty short, just something we need to be mindful of.

(In terms of specifics, we can have up to 60 actions executing at the same time on the hosted Github runners).

[petrhosek]

This should be fine, but we do need to be careful that we don't exceed the Github actions queue and make actions related to other workflows wait. I don't think this will be an issue given the release tests are done on Buildkite (migrating to GHA soonish on self hosted runners) and that they're pretty short, just something we need to be mindful of.

(In terms of specifics, we can have up to 60 actions executing at the same time on the hosted Github runners).

If this becomes an issue, we can change the configuration to only test Debug, Release and MinSizeRel in the full build mode, and for the overlay mode only use one of these configurations since the full build mode should be a superset of the overlay mode.

[boomanaiden154]

Sounds good to me, Thanks!