-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[llvm][GitHub] Move PR project status to Done once backport PR is made #126374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's common to use the /cherry-pick command on a PR to create a backport request. However, this creates a lot of clutter in the LLVM Release Status project, because we end up with two items in the project, one for the original PR and one for the new PR. This change will set the status of the original PR to Done once the new PR (for the release branch) is created. This will save release managers a lot of work of having to manually updated the status for PRs that contain backport requests.
✅ With the latest revision this PR passed the Python code formatter. |
Looks good! It has been annoying to have these issues around. |
tru
approved these changes
Feb 10, 2025
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
llvm#126374) It's common to use the /cherry-pick command on a PR to create a backport request. However, this creates a lot of clutter in the LLVM Release Status project, because we end up with two items in the project, one for the original PR and one for the new PR. This change will set the status of the original PR to Done once the new PR (for the release branch) is created. This will save release managers a lot of work of having to manually updated the status for PRs that contain backport requests.
Looks like this causes a permissions error: https://github.com/llvm/llvm-project/actions/runs/13282944762/job/37085167144
|
@nikic I think this is fixed now, the error shouldn't impact any other parts of the script. |
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
llvm#126374) It's common to use the /cherry-pick command on a PR to create a backport request. However, this creates a lot of clutter in the LLVM Release Status project, because we end up with two items in the project, one for the original PR and one for the new PR. This change will set the status of the original PR to Done once the new PR (for the release branch) is created. This will save release managers a lot of work of having to manually updated the status for PRs that contain backport requests.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
llvm#126374) It's common to use the /cherry-pick command on a PR to create a backport request. However, this creates a lot of clutter in the LLVM Release Status project, because we end up with two items in the project, one for the original PR and one for the new PR. This change will set the status of the original PR to Done once the new PR (for the release branch) is created. This will save release managers a lot of work of having to manually updated the status for PRs that contain backport requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common to use the /cherry-pick command on a PR to create a backport request. However, this creates a lot of clutter in the LLVM Release Status project, because we end up with two items in the project, one for the original PR and one for the new PR.
This change will set the status of the original PR to Done once the new PR (for the release branch) is created. This will save release managers a lot of work of having to manually updated the status for PRs that contain backport requests.