Skip to content

[mlir][emitc] Add an option to cast array type to ptr type #126385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,7 @@ def EmitC_CallOpaqueOp : EmitC_Op<"call_opaque", [CExpression]> {

def EmitC_CastOp : EmitC_Op<"cast",
[CExpression,
DeclareOpInterfaceMethods<CastOpInterface>,
SameOperandsAndResultShape]> {
DeclareOpInterfaceMethods<CastOpInterface>]> {
let summary = "Cast operation";
let description = [{
The `emitc.cast` operation performs an explicit type conversion and is emitted
Expand Down
18 changes: 13 additions & 5 deletions mlir/lib/Dialect/EmitC/IR/EmitC.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,14 @@ LogicalResult emitc::AssignOp::verify() {
bool CastOp::areCastCompatible(TypeRange inputs, TypeRange outputs) {
Type input = inputs.front(), output = outputs.front();

if (auto arrayType = dyn_cast<emitc::ArrayType>(input)) {
if (auto pointerType = dyn_cast<emitc::PointerType>(output)) {
return (arrayType.getElementType() == pointerType.getPointee()) &&
arrayType.getShape().size() == 1 && arrayType.getShape()[0] >= 1;
}
return false;
}

return (
(emitc::isIntegerIndexOrOpaqueType(input) ||
emitc::isSupportedFloatType(input) || isa<emitc::PointerType>(input)) &&
Expand Down Expand Up @@ -699,9 +707,9 @@ void IfOp::print(OpAsmPrinter &p) {

/// Given the region at `index`, or the parent operation if `index` is None,
/// return the successor regions. These are the regions that may be selected
/// during the flow of control. `operands` is a set of optional attributes that
/// correspond to a constant value for each operand, or null if that operand is
/// not a constant.
/// during the flow of control. `operands` is a set of optional attributes
/// that correspond to a constant value for each operand, or null if that
/// operand is not a constant.
void IfOp::getSuccessorRegions(RegionBranchPoint point,
SmallVectorImpl<RegionSuccessor> &regions) {
// The `then` and the `else` region branch back to the parent operation.
Expand Down Expand Up @@ -999,8 +1007,8 @@ emitc::ArrayType::cloneWith(std::optional<ArrayRef<int64_t>> shape,
LogicalResult mlir::emitc::LValueType::verify(
llvm::function_ref<mlir::InFlightDiagnostic()> emitError,
mlir::Type value) {
// Check that the wrapped type is valid. This especially forbids nested lvalue
// types.
// Check that the wrapped type is valid. This especially forbids nested
// lvalue types.
if (!isSupportedEmitCType(value))
return emitError()
<< "!emitc.lvalue must wrap supported emitc type, but got " << value;
Expand Down
38 changes: 35 additions & 3 deletions mlir/test/Dialect/EmitC/invalid_ops.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,41 @@ func.func @cast_tensor(%arg : tensor<f32>) {

// -----

func.func @cast_array(%arg : !emitc.array<4xf32>) {
// expected-error @+1 {{'emitc.cast' op operand type '!emitc.array<4xf32>' and result type '!emitc.array<4xf32>' are cast incompatible}}
%1 = emitc.cast %arg: !emitc.array<4xf32> to !emitc.array<4xf32>
func.func @cast_to_array(%arg : f32) {
// expected-error @+1 {{'emitc.cast' op operand type 'f32' and result type '!emitc.array<4xf32>' are cast incompatible}}
%1 = emitc.cast %arg: f32 to !emitc.array<4xf32>
return
}

// -----

func.func @cast_multidimensional_array(%arg : !emitc.array<1x2xi32>) {
// expected-error @+1 {{'emitc.cast' op operand type '!emitc.array<1x2xi32>' and result type '!emitc.ptr<i32>' are cast incompatible}}
%1 = emitc.cast %arg: !emitc.array<1x2xi32> to !emitc.ptr<i32>
return
}

// -----

func.func @cast_array_zero_rank(%arg : !emitc.array<0xi32>) {
// expected-error @+1 {{'emitc.cast' op operand type '!emitc.array<0xi32>' and result type '!emitc.ptr<i32>' are cast incompatible}}
%1 = emitc.cast %arg: !emitc.array<0xi32> to !emitc.ptr<i32>
return
}

// -----

func.func @cast_array_to_pointer_types_mismatch(%arg : !emitc.array<3xi32>) {
// expected-error @+1 {{'emitc.cast' op operand type '!emitc.array<3xi32>' and result type '!emitc.ptr<f16>' are cast incompatible}}
%1 = emitc.cast %arg: !emitc.array<3xi32> to !emitc.ptr<f16>
return
}

// -----

func.func @cast_pointer_to_array(%arg : !emitc.ptr<i32>) {
// expected-error @+1 {{'emitc.cast' op operand type '!emitc.ptr<i32>' and result type '!emitc.array<3xi32>' are cast incompatible}}
%1 = emitc.cast %arg: !emitc.ptr<i32> to !emitc.array<3xi32>
return
}

Expand Down
5 changes: 5 additions & 0 deletions mlir/test/Dialect/EmitC/ops.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ func.func @cast(%arg0: i32) {
return
}

func.func @cast_array_to_pointer(%arg0: !emitc.array<3xi32>) {
%1 = emitc.cast %arg0: !emitc.array<3xi32> to !emitc.ptr<i32>
return
}

func.func @c() {
%1 = "emitc.constant"(){value = 42 : i32} : () -> i32
%2 = "emitc.constant"(){value = 42 : index} : () -> !emitc.size_t
Expand Down