[Clang][Driver][HIP] Do not specify explicit target cpu in host compilation run line #126488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Aniket Lal (lalaniket8) ChangesThis PR fixes the post merge check fails from PR #125646 Full diff: https://github.com/llvm/llvm-project/pull/126488.diff 1 Files Affected:
diff --git a/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip b/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip
index d26faf7242f915..79a52f0bc89812 100644
--- a/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip
+++ b/clang/test/Driver/dep-file-flag-with-multiple-offload-archs.hip
@@ -8,6 +8,6 @@
// CHECK-NOT: {{.*}}clang{{.*}}"-target-cpu" "gfx1101"{{.*}}"-dependency-file" "tmp.d"
// CHECK: {{.*}}lld{{.*}}"-plugin-opt=mcpu=gfx1101"
// CHECK: {{.*}}clang-offload-bundler
-// CHECK: {{.*}}clang{{.*}}"-target-cpu" "x86-64"{{.*}}"-dependency-file" "tmp.d"
+// CHECK: {{.*}}clang{{.*}}"-target-cpu"{{.*}}"-dependency-file" "tmp.d"
void main(){}
|
vikramRH
approved these changes
Feb 10, 2025
DavidSpickett
approved these changes
Feb 10, 2025
DavidSpickett
deleted the
users/lalaniket8/clang-hip-driver-dependency-file-flag
branch
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
…lation run line (llvm#126488) This PR fixes the post merge check fails from PR llvm#125646 Co-authored-by: anikelal <[email protected]>
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Feb 25, 2025
…lation run line (llvm#126488) This PR fixes the post merge check fails from PR llvm#125646 Co-authored-by: anikelal <[email protected]>
jrbyrnes
pushed a commit
to jrbyrnes/llvm-project
that referenced
this pull request
May 27, 2025
…lation run line (llvm#126488) This PR fixes the post merge check fails from PR llvm#125646 Co-authored-by: anikelal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the post merge check fails from PR #125646