Fix false positive of [[clang::require_explicit_initialization]] on copy/move constructors #126553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: None (higher-performance) ChangesFixes #126490 Full diff: https://github.com/llvm/llvm-project/pull/126553.diff 2 Files Affected:
diff --git a/clang/lib/Sema/SemaInit.cpp b/clang/lib/Sema/SemaInit.cpp
index 308222a79d920c7..18090eb1c9e9ac9 100644
--- a/clang/lib/Sema/SemaInit.cpp
+++ b/clang/lib/Sema/SemaInit.cpp
@@ -4576,7 +4576,9 @@ static void TryConstructorInitialization(Sema &S,
if (!IsListInit &&
(Kind.getKind() == InitializationKind::IK_Default ||
Kind.getKind() == InitializationKind::IK_Direct) &&
- DestRecordDecl != nullptr && DestRecordDecl->isAggregate() &&
+ DestRecordDecl != nullptr &&
+ !(CtorDecl->isCopyOrMoveConstructor() && CtorDecl->isImplicit()) &&
+ DestRecordDecl->isAggregate() &&
DestRecordDecl->hasUninitializedExplicitInitFields()) {
S.Diag(Kind.getLocation(), diag::warn_field_requires_explicit_init)
<< /* Var-in-Record */ 1 << DestRecordDecl;
diff --git a/clang/test/SemaCXX/uninitialized.cpp b/clang/test/SemaCXX/uninitialized.cpp
index 7578b288d7b3fe7..6565bf31e05d72b 100644
--- a/clang/test/SemaCXX/uninitialized.cpp
+++ b/clang/test/SemaCXX/uninitialized.cpp
@@ -1582,7 +1582,21 @@ void aggregate() {
F("___"),
F("____")
};
- (void)ctors;
+
+ struct Copy {
+ Embed e;
+ EmbedDerived ed;
+ F f;
+ Copy(const Copy &c) : e(c.e), ed(c.ed), f(c.f) {} // no-error
+ };
+ F copy1(ctors[0]); // no-error
+ (void)copy1;
+ F copy2{ctors[0]}; // no-error
+ (void)copy2;
+ F copy3 = ctors[0]; // no-error
+ (void)copy3;
+ F copy4 = {ctors[0]}; // no-error
+ (void)copy4;
S::foo(S{1, 2, 3, 4});
S::foo(S{.s1 = 100, .s4 = 100});
|
|
@AaronBallman could we get this in for LLVM 20? |
higher-performance
force-pushed
the
required-fields
branch
3 times, most recently
from
a15c83c to
dc5d3ea
Compare
…opy/move constructors Fixes llvm#126490
higher-performance
force-pushed
the
required-fields
branch
from
dc5d3ea to
dd55dd1
Compare
AaronBallman
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
LGTM, but waiting for @hokein to have a chance to approve as well.
|
thank you! |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/15558 Here is the relevant piece of the build log for the reference |
hokein
reviewed
Feb 11, 2025
| @@ -4576,7 +4576,9 @@ static void TryConstructorInitialization(Sema &S, | |||
| if (!IsListInit && | |||
There was a problem hiding this comment.
nit: I think this if condition is becoming complex enough that it's worth adding a comment for explanation.
|
Oh - @AaronBallman would you mind tagging this for the release so we can cherry pick? |
Sure! |
|
/cherry-pick 90192e8 |
|
/pull-request #126767 |
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Feb 11, 2025
…opy/move constructors (llvm#126553) Fixes llvm#126490 (cherry picked from commit 90192e8)
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
…opy/move constructors (llvm#126553) Fixes llvm#126490
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
…opy/move constructors (llvm#126553) Fixes llvm#126490
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
…opy/move constructors (llvm#126553) Fixes llvm#126490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126490