[lldb][sbapi] Namespace CommandReturnObjectCallbackResult in SBDefines #126606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new callback was added with the type CommandReturnObjectCallbackResult, this commit namespaces that type to match the format of other callback functions have a return type in the lldb namespace. rdar://144553496
|
@llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) ChangesA new callback was added with the type rdar://144553496 Full diff: https://github.com/llvm/llvm-project/pull/126606.diff 1 Files Affected:
diff --git a/lldb/include/lldb/API/SBDefines.h b/lldb/include/lldb/API/SBDefines.h
index b7b5cc06546f86d..ed5a80da117a50a 100644
--- a/lldb/include/lldb/API/SBDefines.h
+++ b/lldb/include/lldb/API/SBDefines.h
@@ -144,7 +144,7 @@ typedef bool (*SBBreakpointHitCallback)(void *baton, lldb::SBProcess &process,
typedef void (*SBDebuggerDestroyCallback)(lldb::user_id_t debugger_id,
void *baton);
-typedef CommandReturnObjectCallbackResult (*SBCommandPrintCallback)(
+typedef lldb::CommandReturnObjectCallbackResult (*SBCommandPrintCallback)(
lldb::SBCommandReturnObject &result, void *baton);
typedef lldb::SBError (*SBPlatformLocateModuleCallback)(
|
bulbazord
approved these changes
Feb 10, 2025
chelcassanova
added a commit
to chelcassanova/llvm-project
that referenced
this pull request
Feb 10, 2025
llvm#126606) A new callback was added with the type CommandReturnObjectCallbackResult, this commit namespaces that type to match the format of other callback functions that have a non-primitive return type in the lldb namespace. rdar://144553496 (cherry picked from commit 7c269cf)
chelcassanova
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Feb 11, 2025
llvm#126606) (#9994) A new callback was added with the type CommandReturnObjectCallbackResult, this commit namespaces that type to match the format of other callback functions that have a non-primitive return type in the lldb namespace. rdar://144553496 (cherry picked from commit 7c269cf)
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
llvm#126606) A new callback was added with the type CommandReturnObjectCallbackResult, this commit namespaces that type to match the format of other callback functions that have a non-primitive return type in the lldb namespace. rdar://144553496
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
llvm#126606) A new callback was added with the type CommandReturnObjectCallbackResult, this commit namespaces that type to match the format of other callback functions that have a non-primitive return type in the lldb namespace. rdar://144553496
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
llvm#126606) A new callback was added with the type CommandReturnObjectCallbackResult, this commit namespaces that type to match the format of other callback functions that have a non-primitive return type in the lldb namespace. rdar://144553496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new callback was added with the type
CommandReturnObjectCallbackResult, this commit namespaces that type to match the format of other callback functions that have a non-primitive return type in the lldb namespace.
rdar://144553496