release/19.x: [llvm][Mips] Bail on underaligned loads/stores in FastISel. (#106231) #126693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) We encountered this problem in Zig, causing all of our `mips(el)-linux-gnueabi*` tests to fail: ziglang/zig#21215 For these unusual cases, let's just bail in `MipsFastISel` since `MipsTargetLowering` can handle them fine. Note: I don't have commit access. (cherry picked from commit c0b3e49)
|
@alexrp What do you think about merging this PR to the release branch? |
|
Fine by me, but I was under the impression that there won't be any more 19.x releases? |
That is the case so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c0b3e49
Requested by: @wzssyqa