-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[llvm] [cmake] Expose LLVM_BUILD_TELEMETRY
in LLVMConfig.cmake
#126710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in `LLVMConfig.cmake`. This fixes telemetry library being misdetected as `OFF` when building LLDB standalone. Fixes bac62ee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me, but I'll leave it to an LLDB developer to approve, since they'll be better able to confirm this fixes the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I guess this also needs a backport to 20.x.
I don't think lldb telemetry is part of 20.x.
Well, I was referring to the fact that bac62ee mentioned backporting the flag, and I believe this to be reasonable part of the flag, even if it weren't really used inside LLVM project at the time. |
…lvm#126710) Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in `LLVMConfig.cmake`. This fixes telemetry library being misdetected as `OFF` when building LLDB standalone. Fixes bac62ee. ------ I guess this also needs a backport to 20.x.
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2273 Here is the relevant piece of the build log for the reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…lvm#126710) Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in `LLVMConfig.cmake`. This fixes telemetry library being misdetected as `OFF` when building LLDB standalone. Fixes bac62ee. ------ I guess this also needs a backport to 20.x. (cherry picked from commit 2ad9d5f)
…lvm#126710) Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in `LLVMConfig.cmake`. This fixes telemetry library being misdetected as `OFF` when building LLDB standalone. Fixes bac62ee. ------ I guess this also needs a backport to 20.x.
…lvm#126710) Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in `LLVMConfig.cmake`. This fixes telemetry library being misdetected as `OFF` when building LLDB standalone. Fixes bac62ee. ------ I guess this also needs a backport to 20.x.
…lvm#126710) Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in `LLVMConfig.cmake`. This fixes telemetry library being misdetected as `OFF` when building LLDB standalone. Fixes bac62ee. ------ I guess this also needs a backport to 20.x.
Add
LLVM_BUILD_TELEMETRY
to the list of flags exposed inLLVMConfig.cmake
. This fixes telemetry library being misdetected asOFF
when building LLDB standalone.Fixes bac62ee.
I guess this also needs a backport to 20.x.