Skip to content

[llvm] [cmake] Expose LLVM_BUILD_TELEMETRY in LLVMConfig.cmake #126710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

mgorny
Copy link
Member

@mgorny mgorny commented Feb 11, 2025

Add LLVM_BUILD_TELEMETRY to the list of flags exposed in LLVMConfig.cmake. This fixes telemetry library being misdetected as OFF when building LLDB standalone.

Fixes bac62ee.


I guess this also needs a backport to 20.x.

Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed
in `LLVMConfig.cmake`.  This fixes telemetry library being misdetected
as `OFF` when building LLDB standalone.

Fixes bac62ee.
@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Feb 11, 2025
Copy link
Collaborator

@jh7370 jh7370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but I'll leave it to an LLDB developer to approve, since they'll be better able to confirm this fixes the issue.

Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I guess this also needs a backport to 20.x.

I don't think lldb telemetry is part of 20.x.

@mgorny
Copy link
Member Author

mgorny commented Feb 11, 2025

I don't think lldb telemetry is part of 20.x.

Well, I was referring to the fact that bac62ee mentioned backporting the flag, and I believe this to be reasonable part of the flag, even if it weren't really used inside LLVM project at the time.

@mgorny mgorny merged commit 2ad9d5f into llvm:main Feb 11, 2025
10 checks passed
@mgorny mgorny deleted the telemetry-export branch February 11, 2025 16:20
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
…lvm#126710)

Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in
`LLVMConfig.cmake`. This fixes telemetry library being misdetected as
`OFF` when building LLDB standalone.

Fixes bac62ee.

------

I guess this also needs a backport to 20.x.
@llvm-ci
Copy link
Collaborator

llvm-ci commented Feb 12, 2025

LLVM Buildbot has detected a new failure on builder lld-x86_64-win running on as-worker-93 while building llvm at step 7 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2273

Here is the relevant piece of the build log for the reference
Step 7 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM-Unit :: Support/./SupportTests.exe/38/87' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe-LLVM-Unit-9612-38-87.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=87 GTEST_SHARD_INDEX=38 C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe
--

Script:
--
C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe --gtest_filter=ProgramEnvTest.CreateProcessLongPath
--
C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(160): error: Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(163): error: fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied



C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:160
Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:163
fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied




********************


Copy link
Member

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request Feb 13, 2025
…lvm#126710)

Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in
`LLVMConfig.cmake`. This fixes telemetry library being misdetected as
`OFF` when building LLDB standalone.

Fixes bac62ee.

------

I guess this also needs a backport to 20.x.

(cherry picked from commit 2ad9d5f)
flovent pushed a commit to flovent/llvm-project that referenced this pull request Feb 13, 2025
…lvm#126710)

Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in
`LLVMConfig.cmake`. This fixes telemetry library being misdetected as
`OFF` when building LLDB standalone.

Fixes bac62ee.

------

I guess this also needs a backport to 20.x.
joaosaffran pushed a commit to joaosaffran/llvm-project that referenced this pull request Feb 14, 2025
…lvm#126710)

Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in
`LLVMConfig.cmake`. This fixes telemetry library being misdetected as
`OFF` when building LLDB standalone.

Fixes bac62ee.

------

I guess this also needs a backport to 20.x.
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Feb 24, 2025
…lvm#126710)

Add `LLVM_BUILD_TELEMETRY` to the list of flags exposed in
`LLVMConfig.cmake`. This fixes telemetry library being misdetected as
`OFF` when building LLDB standalone.

Fixes bac62ee.

------

I guess this also needs a backport to 20.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants