Skip to content

[AMDGPU] Change handling of unsupported non-compute shaders with HSA #126798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2025
Merged

[AMDGPU] Change handling of unsupported non-compute shaders with HSA #126798

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b45c112
[AMDGPU] Change handling of unsupported non-compute shaders with HSA
ro-i Feb 11, 2025
891ba84
implement feedback
ro-i Feb 12, 2025
61161b8
fix formatting
ro-i Feb 12, 2025
a221782
implement feedback
ro-i Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions llvm/lib/Target/AMDGPU/SIISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2824,10 +2824,7 @@ SDValue SITargetLowering::LowerFormalArguments(
SIMachineFunctionInfo *Info = MF.getInfo<SIMachineFunctionInfo>();

if (Subtarget->isAmdHsaOS() && AMDGPU::isGraphics(CallConv)) {
DiagnosticInfoUnsupported NoGraphicsHSA(
Fn, "unsupported non-compute shaders with HSA", DL.getDebugLoc());
DAG.getContext()->diagnose(NoGraphicsHSA);
return DAG.getEntryNode();
report_fatal_error("unsupported non-compute shaders with HSA");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a fatal error. You should adjust the return value to be the correct type by using the correct set of undef values

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point? There will be no valid output anyways. Trying to validate even invalid output takes a lot of effort and will ityself be fragile because that code is rarely executed/tested.

}

SmallVector<ISD::InputArg, 16> Splits;
Expand Down
19 changes: 0 additions & 19 deletions llvm/test/CodeGen/AMDGPU/no-hsa-graphics-shaders.ll
View file
Open in desktop

This file was deleted.