[libc] fix get_epoch constexpr error

[michaelrj-google]

get_epoch calls mktime_internal which isn't constexpr. For now, just
remove the constexpr from get_epoch.

[llvmbot]

@llvm/pr-subscribers-libc

Author: Michael Jones (michaelrj-google)

Changes

get_epoch calls mktime_internal which isn't constexpr. For now, just
remove the constexpr from get_epoch.

---

Full diff: https://github.com/llvm/llvm-project/pull/126818.diff

1 Files Affected:

• (modified) libc/src/time/time_utils.h (+1-3)

diff --git a/libc/src/time/time_utils.h b/libc/src/time/time_utils.h
index 30cdcbc170639..324e129f6f780 100644
--- a/libc/src/time/time_utils.h
+++ b/libc/src/time/time_utils.h
@@ -328,9 +328,7 @@ class TMReader final {
     return BASE_YEAR + IS_NEXT_YEAR;
   }
 
-  LIBC_INLINE constexpr time_t get_epoch() const {
-    return mktime_internal(timeptr);
-  }
+  LIBC_INLINE time_t get_epoch() const { return mktime_internal(timeptr); }
 
   // returns the timezone offset in microwave time:
   // return (hours * 100) + minutes;

[lntue]

Is there anything preventing mktime_internal to be constexpr?

[michaelrj-google]

Is there anything preventing mktime_internal to be constexpr?

I'd need to move it to be in the header. We can do that in future, but for now I'm going to land this to fix the buildbots

[nickdesaulniers]

Fixes: #126138