ConstRange: exhaustively test makeExactICmpRegion

[artagnon]

Exhaustively test makeExactICmpRegion by comparing makeAllowedICmpRegion against makeSatisfyingICmpRegion for all APInts.

[llvmbot]

@llvm/pr-subscribers-llvm-ir

Author: Ramkumar Ramachandra (artagnon)

Changes

Exhaustively test makeExactICmpRegion by comparing makeAllowedICmpRegion against makeSatisfyingICmpRegion for all APInts.

---

Full diff: https://github.com/llvm/llvm-project/pull/127058.diff

1 Files Affected:

• (modified) llvm/unittests/IR/ConstantRangeTest.cpp (+11)

diff --git a/llvm/unittests/IR/ConstantRangeTest.cpp b/llvm/unittests/IR/ConstantRangeTest.cpp
index c390ffea1c352..a85e111146c01 100644
--- a/llvm/unittests/IR/ConstantRangeTest.cpp
+++ b/llvm/unittests/IR/ConstantRangeTest.cpp
@@ -1638,6 +1638,17 @@ TEST(ConstantRange, MakeAllowedICmpRegion) {
                   .isEmptySet());
 }
 
+TEST(ConstantRange, MakeExactICmpRegion) {
+  for (unsigned Bits : {1, 4}) {
+    EnumerateAPInts(Bits, [](const APInt &N) {
+      for (auto Pred : ICmpInst::predicates()) {
+        EXPECT_EQ(ConstantRange::makeAllowedICmpRegion(Pred, N),
+                  ConstantRange::makeSatisfyingICmpRegion(Pred, N));
+      };
+    });
+  }
+}
+
 TEST(ConstantRange, MakeSatisfyingICmpRegion) {
   ConstantRange LowHalf(APInt(8, 0), APInt(8, 128));
   ConstantRange HighHalf(APInt(8, 128), APInt(8, 0));

[dtcxzyw]

Should we remove the assertion here?

llvm-project/llvm/lib/IR/ConstantRange.cpp

Line 166 in 2db2628

assert(makeAllowedICmpRegion(Pred, C) == makeSatisfyingICmpRegion(Pred, C));

Do you have a plan to test with samesign in follow-up patches?

[artagnon]

Should we remove the assertion here?

llvm-project/llvm/lib/IR/ConstantRange.cpp

Line 166 in 2db2628

assert(makeAllowedICmpRegion(Pred, C) == makeSatisfyingICmpRegion(Pred, C));

Good idea.

Do you have a plan to test with samesign in follow-up patches?

As I described on the other patch, samesign produces a disjoint union of two ConstantRanges, so I don't think it makes sense to teach ConstantRange about samesign anymore.