[lldb] Remove UtilityTests->Target dep #127060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's completely unnecessary right now, but having it present means that some real unwanted dependencies could sneak it. (This also makes building the test binary much faster.)
|
@llvm/pr-subscribers-lldb Author: Pavel Labath (labath) ChangesIt's completely unnecessary right now, but having it present means that some real unwanted dependencies could sneak in. (This also makes building the test binary much faster.) Full diff: https://github.com/llvm/llvm-project/pull/127060.diff 2 Files Affected:
diff --git a/lldb/unittests/Utility/CMakeLists.txt b/lldb/unittests/Utility/CMakeLists.txt
index 3a73bdc3e9e1a..8d4e2ea35f267 100644
--- a/lldb/unittests/Utility/CMakeLists.txt
+++ b/lldb/unittests/Utility/CMakeLists.txt
@@ -52,7 +52,6 @@ add_lldb_unittest(UtilityTests
XcodeSDKTest.cpp
LINK_LIBS
- lldbTarget
lldbUtility
lldbUtilityHelpers
LLVMTestingSupport
diff --git a/lldb/unittests/Utility/ProcessInstanceInfoTest.cpp b/lldb/unittests/Utility/ProcessInstanceInfoTest.cpp
index 3ba35d4efacc1..b653df5fe01a1 100644
--- a/lldb/unittests/Utility/ProcessInstanceInfoTest.cpp
+++ b/lldb/unittests/Utility/ProcessInstanceInfoTest.cpp
@@ -6,7 +6,11 @@
//
//===----------------------------------------------------------------------===//
-#include "lldb/Target/Process.h"
+#include "lldb/Utility/ArchSpec.h"
+#include "lldb/Utility/ProcessInfo.h"
+#include "lldb/Utility/StreamString.h"
+#include "lldb/Utility/UserIDResolver.h"
+#include "llvm/ADT/Twine.h"
#include "gtest/gtest.h"
#include <optional>
|
JDevlieghere
approved these changes
Feb 13, 2025
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
It's completely unnecessary right now, but having it present means that some real unwanted dependencies could sneak in. (This also makes building the test binary much faster.)
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
It's completely unnecessary right now, but having it present means that some real unwanted dependencies could sneak in. (This also makes building the test binary much faster.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's completely unnecessary right now, but having it present means that some real unwanted dependencies could sneak in. (This also makes building the test binary much faster.)