[AMDGPU] Skip -mattr=dumpcode test on big-endian hosts #127064
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not know that the output is different depending on the host endianness. This should be fixed properly but in the mean time this patch fixes the buildbot failures.
|
@llvm/pr-subscribers-backend-amdgpu Author: Jay Foad (jayfoad) ChangesI did not know that the output is different depending on the host Full diff: https://github.com/llvm/llvm-project/pull/127064.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/AMDGPU/dumpcode.ll b/llvm/test/CodeGen/AMDGPU/dumpcode.ll
index 1acec2997aa8f..27205cb644436 100644
--- a/llvm/test/CodeGen/AMDGPU/dumpcode.ll
+++ b/llvm/test/CodeGen/AMDGPU/dumpcode.ll
@@ -1,4 +1,5 @@
; RUN: llc -mtriple=amdgcn -mcpu=gfx1010 -mattr=dumpcode -filetype=obj < %s | llvm-objcopy --dump-section .AMDGPU.disasm=- - /dev/null | FileCheck %s -check-prefix=GFX10
+; REQUIRES: host-byteorder-little-endian
; GFX10: f:
; GFX10-NEXT: BB0_0:
|
arsenm
approved these changes
Feb 13, 2025
kosarev
approved these changes
Feb 13, 2025
|
Closing in favour of #127073. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not know that the output is different depending on the host
endianness. This should be fixed properly but in the mean time this
patch fixes the buildbot failures.