Skip to content

[ORC][unittests] Remove hard coded 16k page size #127115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

RossComputerGuy
Copy link
Member

Fixes a couple hard coded 16k values which is being used as the page size. Replaces the hard coded value with the system's page size. This fixes #116753 on an Ampere Altra Q64-22

CC @lhames

Copy link

github-actions bot commented Feb 13, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

Copy link
Contributor

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @RossComputerGuy!

@lhames lhames merged commit 415607e into llvm:main Feb 13, 2025
8 checks passed
@RossComputerGuy RossComputerGuy deleted the fix/orc-units branch February 13, 2025 23:01
joaosaffran pushed a commit to joaosaffran/llvm-project that referenced this pull request Feb 14, 2025
Fixes a couple hard coded 16k values which is being used as the page
size. Replaces the hard coded value with the system's page size. This
fixes llvm#116753 on an Ampere Altra Q64-22

CC @lhames
swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request Feb 14, 2025
Fixes a couple hard coded 16k values which is being used as the page
size. Replaces the hard coded value with the system's page size. This
fixes llvm#116753 on an Ampere Altra Q64-22

CC @lhames

(cherry picked from commit 415607e)
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Feb 24, 2025
Fixes a couple hard coded 16k values which is being used as the page
size. Replaces the hard coded value with the system's page size. This
fixes llvm#116753 on an Ampere Altra Q64-22

CC @lhames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM test failure on aarch64-linux
2 participants