Skip to content

[flang][cuda] Set cudadevice interfaces as public by default #127229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

clementval
Copy link
Contributor

Remove the PRIVATE statement from cudadevice as it hides any interfaces from the used __cuda_device module.

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Feb 14, 2025
Copy link
Contributor

@Renaud-K Renaud-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be a lot simpler. Thanks.

@clementval clementval merged commit 004afcb into llvm:main Feb 14, 2025
10 checks passed
@clementval clementval deleted the cuf_cudadevice_public branch February 14, 2025 18:26
joaosaffran pushed a commit to joaosaffran/llvm-project that referenced this pull request Feb 14, 2025
…7229)

Remove the PRIVATE statement from cudadevice as it hides any interfaces
from the used __cuda_device module.
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Feb 24, 2025
…7229)

Remove the PRIVATE statement from cudadevice as it hides any interfaces
from the used __cuda_device module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants