[lld][MachO] Test with exported_symbol and exported_symbols_list together #127243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lld Author: Ellis Hoag (ellishg) ChangesI've been investigating a bug involving Full diff: https://github.com/llvm/llvm-project/pull/127243.diff 1 Files Affected:
diff --git a/lld/test/MachO/export-options.s b/lld/test/MachO/export-options.s
index 1a5d409e83383..df2f90e3a4f3f 100644
--- a/lld/test/MachO/export-options.s
+++ b/lld/test/MachO/export-options.s
@@ -117,13 +117,15 @@
## Check that only string-literal patterns match
## Check that comments and blank lines are stripped from symbol list
# RUN: %lld -dylib %t/symdefs.o -o %t/literal \
-# RUN: -exported_symbols_list %t/literals.txt
+# RUN: -exported_symbols_list %t/literals.txt \
+# RUN: -exported_symbol singleton
# RUN: llvm-objdump --macho --exports-trie %t/literal | \
# RUN: FileCheck --check-prefix=LITERAL %s
# LITERAL-DAG: literal_only
# LITERAL-DAG: literal_also
# LITERAL-DAG: globby_also
+# LITERAL-DAG: singleton
# LITERAL-NOT: globby_only
## Check that only glob patterns match
@@ -245,7 +247,7 @@ _keep_lazy:
#--- symdefs.s
-.globl literal_only, literal_also, globby_only, globby_also
+.globl literal_only, literal_also, globby_only, globby_also, singleton
literal_only:
retq
literal_also:
@@ -254,6 +256,8 @@ globby_only:
retq
globby_also:
retq
+singleton:
+ retq
#--- literals.txt
|
|
@llvm/pr-subscribers-lld-macho Author: Ellis Hoag (ellishg) ChangesI've been investigating a bug involving Full diff: https://github.com/llvm/llvm-project/pull/127243.diff 1 Files Affected:
diff --git a/lld/test/MachO/export-options.s b/lld/test/MachO/export-options.s
index 1a5d409e83383..df2f90e3a4f3f 100644
--- a/lld/test/MachO/export-options.s
+++ b/lld/test/MachO/export-options.s
@@ -117,13 +117,15 @@
## Check that only string-literal patterns match
## Check that comments and blank lines are stripped from symbol list
# RUN: %lld -dylib %t/symdefs.o -o %t/literal \
-# RUN: -exported_symbols_list %t/literals.txt
+# RUN: -exported_symbols_list %t/literals.txt \
+# RUN: -exported_symbol singleton
# RUN: llvm-objdump --macho --exports-trie %t/literal | \
# RUN: FileCheck --check-prefix=LITERAL %s
# LITERAL-DAG: literal_only
# LITERAL-DAG: literal_also
# LITERAL-DAG: globby_also
+# LITERAL-DAG: singleton
# LITERAL-NOT: globby_only
## Check that only glob patterns match
@@ -245,7 +247,7 @@ _keep_lazy:
#--- symdefs.s
-.globl literal_only, literal_also, globby_only, globby_also
+.globl literal_only, literal_also, globby_only, globby_also, singleton
literal_only:
retq
literal_also:
@@ -254,6 +256,8 @@ globby_only:
retq
globby_also:
retq
+singleton:
+ retq
#--- literals.txt
|
carlocab
approved these changes
Feb 15, 2025
wldfngrs
pushed a commit
to wldfngrs/llvm-project
that referenced
this pull request
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been investigating a bug involving
-exported_symboland I discovered that we have no test that uses both-exported_symboland-exported_symbols_listtogether. Add this test to ensure they do not override each other now or in the future.