Skip to content

[SelectionDAG] Remove lowerCallToExternalSymbol #127408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kazutakahirata
Copy link
Contributor

The last use was removed in:

commit 05e6bb4
Author: Roger Ferrer Ibáñez [email protected]
Date: Thu May 30 14:55:32 2024 +0200

The last use was removed in:

  commit 05e6bb4
  Author: Roger Ferrer Ibáñez <[email protected]>
  Date:   Thu May 30 14:55:32 2024 +0200
@llvmbot llvmbot added the llvm:SelectionDAG SelectionDAGISel as well label Feb 16, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 16, 2025

@llvm/pr-subscribers-llvm-selectiondag

Author: Kazu Hirata (kazutakahirata)

Changes

The last use was removed in:

commit 05e6bb4
Author: Roger Ferrer Ibáñez <[email protected]>
Date: Thu May 30 14:55:32 2024 +0200


Full diff: https://github.com/llvm/llvm-project/pull/127408.diff

2 Files Affected:

  • (modified) llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (-9)
  • (modified) llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h (-3)
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
index cac25fd7c1025..78a6e24e5b8d2 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -6281,15 +6281,6 @@ static unsigned FixedPointIntrinsicToOpcode(unsigned Intrinsic) {
   }
 }
 
-void SelectionDAGBuilder::lowerCallToExternalSymbol(const CallInst &I,
-                                           const char *FunctionName) {
-  assert(FunctionName && "FunctionName must not be nullptr");
-  SDValue Callee = DAG.getExternalSymbol(
-      FunctionName,
-      DAG.getTargetLoweringInfo().getPointerTy(DAG.getDataLayout()));
-  LowerCallTo(I, Callee, I.isTailCall(), I.isMustTailCall());
-}
-
 /// Given a @llvm.call.preallocated.setup, return the corresponding
 /// preallocated call.
 static const CallBase *FindPreallocatedCall(const Value *PreallocatedSetup) {
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
index ece48c9bedf72..8496f8ae78ce6 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
@@ -705,9 +705,6 @@ class SelectionDAGBuilder {
                           DIExpression *Expr, const DebugLoc &dl,
                           unsigned DbgSDNodeOrder);
 
-  /// Lowers CallInst to an external symbol.
-  void lowerCallToExternalSymbol(const CallInst &I, const char *FunctionName);
-
   SDValue lowerStartEH(SDValue Chain, const BasicBlock *EHPadBB,
                        MCSymbol *&BeginLabel);
   SDValue lowerEndEH(SDValue Chain, const InvokeInst *II,

@kazutakahirata kazutakahirata merged commit 153dd19 into llvm:main Feb 17, 2025
10 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_remove_llvm_CodeGen_lowerCallToExternalSymbol branch February 17, 2025 08:06
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Feb 24, 2025
The last use was removed in:

  commit 05e6bb4
  Author: Roger Ferrer Ibáñez <[email protected]>
  Date:   Thu May 30 14:55:32 2024 +0200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:SelectionDAG SelectionDAGISel as well
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants