Skip to content

[DebugInfo] Avoid repeated hash lookups (NFC) #127446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

[DebugInfo] Avoid repeated hash lookups (NFC) #127446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,20 +65,24 @@ LVSectionIndex LVSymbolTable::update(LVScope *Function) {
Name = Function->getName();
std::string SymbolName(Name);

if (SymbolName.empty() || (SymbolNames.find(SymbolName) == SymbolNames.end()))
if (SymbolName.empty())
return SectionIndex;

auto It = SymbolNames.find(SymbolName);
if (It == SymbolNames.end())
return SectionIndex;

// Update a recorded entry with its logical scope, only if the scope has
// ranges. That is the case when in DWARF there are 2 DIEs connected via
// the DW_AT_specification.
if (Function->getHasRanges()) {
SymbolNames[SymbolName].Scope = Function;
SectionIndex = SymbolNames[SymbolName].SectionIndex;
It->second.Scope = Function;
SectionIndex = It->second.SectionIndex;
} else {
SectionIndex = UndefinedSectionIndex;
}

if (SymbolNames[SymbolName].IsComdat)
if (It->second.IsComdat)
Function->setIsComdat();

LLVM_DEBUG({ print(dbgs()); });
Expand Down