Skip to content

[Analysis] Remove getGuaranteedWellDefinedOps #127453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kazutakahirata
Copy link
Contributor

The last use was removed in:

commit ac9e677
Author: Yingwei Zheng [email protected]
Date: Mon Feb 26 01:53:16 2024 +0800

The last use was removed in:

  commit ac9e677
  Author: Yingwei Zheng <[email protected]>
  Date:   Mon Feb 26 01:53:16 2024 +0800
@llvmbot llvmbot added the llvm:analysis Includes value tracking, cost tables and constant folding label Feb 17, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 17, 2025

@llvm/pr-subscribers-llvm-analysis

Author: Kazu Hirata (kazutakahirata)

Changes

The last use was removed in:

commit ac9e677
Author: Yingwei Zheng <[email protected]>
Date: Mon Feb 26 01:53:16 2024 +0800


Full diff: https://github.com/llvm/llvm-project/pull/127453.diff

2 Files Affected:

  • (modified) llvm/include/llvm/Analysis/ValueTracking.h (-6)
  • (modified) llvm/lib/Analysis/ValueTracking.cpp (-8)
diff --git a/llvm/include/llvm/Analysis/ValueTracking.h b/llvm/include/llvm/Analysis/ValueTracking.h
index dba54be4c92f8..1b49f8a3e85b1 100644
--- a/llvm/include/llvm/Analysis/ValueTracking.h
+++ b/llvm/include/llvm/Analysis/ValueTracking.h
@@ -1004,12 +1004,6 @@ bool propagatesPoison(const Use &PoisonOp);
 void getGuaranteedNonPoisonOps(const Instruction *I,
                                SmallVectorImpl<const Value *> &Ops);
 
-/// Insert operands of I into Ops such that I will trigger undefined behavior
-/// if I is executed and that operand is not a well-defined value
-/// (i.e. has undef bits or poison).
-void getGuaranteedWellDefinedOps(const Instruction *I,
-                                 SmallVectorImpl<const Value *> &Ops);
-
 /// Return true if the given instruction must trigger undefined behavior
 /// when I is executed with any operands which appear in KnownPoison holding
 /// a poison value at the point of execution.
diff --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp
index 2a49a10447e0b..e4454c42c7857 100644
--- a/llvm/lib/Analysis/ValueTracking.cpp
+++ b/llvm/lib/Analysis/ValueTracking.cpp
@@ -8175,14 +8175,6 @@ static bool handleGuaranteedWellDefinedOps(const Instruction *I,
   return false;
 }
 
-void llvm::getGuaranteedWellDefinedOps(
-    const Instruction *I, SmallVectorImpl<const Value *> &Operands) {
-  handleGuaranteedWellDefinedOps(I, [&](const Value *V) {
-    Operands.push_back(V);
-    return false;
-  });
-}
-
 /// Enumerates all operands of \p I that are guaranteed to not be poison.
 template <typename CallableT>
 static bool handleGuaranteedNonPoisonOps(const Instruction *I,

@kazutakahirata kazutakahirata merged commit e0545b5 into llvm:main Feb 17, 2025
10 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_remove_llvm_getGuaranteedWellDefinedOps branch February 17, 2025 09:22
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Feb 24, 2025
The last use was removed in:

  commit ac9e677
  Author: Yingwei Zheng <[email protected]>
  Date:   Mon Feb 26 01:53:16 2024 +0800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:analysis Includes value tracking, cost tables and constant folding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants