Skip to content

[compiler-rt][asan] Re-enable forkpty test on AArch64 (NFC) #127667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

c-rhodes
Copy link
Collaborator

Disabled in 86474c7, no longer failing on AArch64 (for me at least).

Fixes: #24774

Disabled in 86474c7, no longer failing
on AArch64 (for me at least).

Fixes: llvm#24774
@llvmbot
Copy link
Member

llvmbot commented Feb 18, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Cullen Rhodes (c-rhodes)

Changes

Disabled in 86474c7, no longer failing on AArch64 (for me at least).

Fixes: #24774


Full diff: https://github.com/llvm/llvm-project/pull/127667.diff

1 Files Affected:

  • (modified) compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp (-1)
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp
index 2711cfb112959..a4ca4a3c2f35d 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp
@@ -3,7 +3,6 @@
 // Ignore leaks as this is not the point of test, but HWASAN repors one here.
 // RUN: %env_tool_opts=detect_leaks=0 %run %t | FileCheck %s
 
-// REQUIRES: stable-runtime
 // XFAIL: android && asan
 
 // No libutil.

Copy link
Collaborator

@vitalybuka vitalybuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try

@vitalybuka vitalybuka merged commit 61cfa53 into llvm:main Feb 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ASAN / AArch64] forkpty fails on AArch64
3 participants