Skip to content

[libc++] Re-enable the FreeBSD CI job #127687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Feb 18, 2025

Technical issues have apparently been resolved and the node should be back online.

Closes #117780

@ldionne ldionne requested a review from a team as a code owner February 18, 2025 19:23
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Feb 18, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 18, 2025

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

Technical issues have apparently been resolved and the node should be back online.

Closes #117780


Full diff: https://github.com/llvm/llvm-project/pull/127687.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/buildkite-pipeline.yml (+11-13)
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index df0e5d4d12f9f..b8e982b653d39 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -115,19 +115,17 @@ steps:
       os: aix
     <<: *common
 
-# TODO: Re-enable this when the FreeBSD runners are back online
-#       https://github.com/llvm/llvm-project/issues/117780
-# - group: ':freebsd: FreeBSD'
-#   steps:
-#   - label: FreeBSD 13 amd64
-#     command: libcxx/utils/ci/run-buildbot generic-cxx26
-#     env:
-#       CC: clang17
-#       CXX: clang++17
-#     agents:
-#       queue: libcxx-builders
-#       os: freebsd
-#     <<: *common
+- group: ':freebsd: FreeBSD'
+  steps:
+  - label: FreeBSD 13 amd64
+    command: libcxx/utils/ci/run-buildbot generic-cxx26
+    env:
+      CC: clang17
+      CXX: clang++17
+    agents:
+      queue: libcxx-builders
+      os: freebsd
+    <<: *common
 
 - group: ':android: Android'
   steps:

Technical issues have apparently been resolved and
the node should be back online.

Closes llvm#117780.
@ldionne ldionne force-pushed the review/resume-freebsd-ci branch from 431e9e2 to 924411b Compare February 19, 2025 22:17
@ldionne ldionne added the pending-ci Merging the PR is only pending completion of CI label Feb 20, 2025
@ldionne
Copy link
Member Author

ldionne commented Feb 21, 2025

The failure is a fluke of the Android runner, merging.

@ldionne ldionne merged commit aa6d3ff into llvm:main Feb 21, 2025
80 of 84 checks passed
@ldionne ldionne deleted the review/resume-freebsd-ci branch February 21, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. pending-ci Merging the PR is only pending completion of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FreeBSD libc++ CI needs upgrading
2 participants