-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[libc] Add strftime_l #127708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+90
−1
Merged
[libc] Add strftime_l #127708
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,6 +150,20 @@ add_entrypoint_object( | |
libc.src.time.strftime_core.strftime_main | ||
) | ||
|
||
add_entrypoint_object( | ||
strftime_l | ||
SRCS | ||
strftime_l.cpp | ||
HDRS | ||
strftime_l.h | ||
DEPENDS | ||
libc.hdr.types.locale_t | ||
libc.hdr.types.size_t | ||
libc.hdr.types.struct_tm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this needs the rest of the dependencies from strftime There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
libc.src.stdio.printf_core.writer | ||
libc.src.time.strftime_core.strftime_main | ||
) | ||
|
||
add_entrypoint_object( | ||
time | ||
SRCS | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
//===-- Implementation of strftime_l function -----------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "src/time/strftime_l.h" | ||
#include "hdr/types/size_t.h" | ||
#include "hdr/types/struct_tm.h" | ||
#include "include/llvm-libc-types/locale_t.h" | ||
#include "src/__support/common.h" | ||
#include "src/__support/macros/config.h" | ||
#include "src/stdio/printf_core/writer.h" | ||
#include "src/time/strftime_core/strftime_main.h" | ||
|
||
namespace LIBC_NAMESPACE_DECL { | ||
|
||
// TODO: Add support for locales. | ||
LLVM_LIBC_FUNCTION(size_t, strftime_l, | ||
(char *__restrict buffer, size_t count, | ||
const char *__restrict format, | ||
const struct tm *__restrict tp, locale_t)) { | ||
printf_core::WriteBuffer wb(buffer, (buffsz > 0 ? buffsz - 1 : 0)); | ||
printf_core::Writer writer(&wb); | ||
int ret = strftime_core::strftime_main(&writer, format, timeptr); | ||
if (buffsz > 0) // if the buffsz is 0 the buffer may be a null pointer. | ||
wb.buff[wb.buff_cur] = '\0'; | ||
return (ret < 0 || static_cast<size_t>(ret) > buffsz) ? 0 : ret; | ||
} | ||
|
||
} // namespace LIBC_NAMESPACE_DECL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
//===-- Implementation header for strftime_l --------------------*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef LLVM_LIBC_SRC_TIME_STRFTIME_L_H | ||
#define LLVM_LIBC_SRC_TIME_STRFTIME_L_H | ||
|
||
#include "hdr/types/size_t.h" | ||
#include "hdr/types/struct_tm.h" | ||
#include "include/llvm-libc-types/locale_t.h" | ||
#include "src/__support/macros/config.h" | ||
|
||
namespace LIBC_NAMESPACE_DECL { | ||
|
||
size_t strftime_l(char *__restrict buffer, size_t count, | ||
const char *__restrict format, const struct tm *__restrict tp, | ||
locale_t); | ||
|
||
} // namespace LIBC_NAMESPACE_DECL | ||
|
||
#endif // LLVM_LIBC_SRC_TIME_STRFTIME_L_H |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add
strftime_l
to the other targets as well. I should probably also look into addingstrftime
to more targets, I think I only added it to x86_64/linuxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.