[CIR] updates test for 75ea7aed #127917
Merged
[CIR] updates test for 75ea7aed #127917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clangir Author: Christopher Di Bella (cjdb) ChangesFull diff: https://github.com/llvm/llvm-project/pull/127917.diff 1 Files Affected:
diff --git a/clang/test/CIR/emit-actions.cpp b/clang/test/CIR/emit-actions.cpp
index 94ddf23b34753..969c10a1fc2bc 100644
--- a/clang/test/CIR/emit-actions.cpp
+++ b/clang/test/CIR/emit-actions.cpp
@@ -11,7 +11,7 @@
int x = 1;
-// BC: @x = dso_local global i32 1
+// BC: @x = global i32 1, align 4
// ASM: x:
// ASM: .long 1
|
andykaylor
reviewed
Feb 20, 2025
clang/test/CIR/emit-actions.cpp
Outdated
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| int x = 1; | |||
|
|
|||
| // BC: @x = dso_local global i32 1 | |||
| // BC: @x = global i32 1, align 4 | |||
There was a problem hiding this comment.
I didn't get any buildbot notifications about this test failing. Where are you seeing this failure?
There was a problem hiding this comment.
Oh, I guess I wouldn't see buildbot failures, since we don't have a buildbot with ClangIR enabled. I haven't seen it fail locally though.
There was a problem hiding this comment.
This is happening when I run the tests inside Google's infra. I've updated the commit so that it works both inside and out.
|
Thanks! |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/7301 Here is the relevant piece of the build log for the reference |
bcardosolopes
pushed a commit
to bcardosolopes/llvm-project
that referenced
this pull request
Mar 6, 2025
This reverts commit 131a3cf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.