[AsmPrinter] Simplify $local after D131429. NFC

[MaskRay]

setType is unneeded (and AsmPrinter tries not to modify symbols).
AsmPrinter. MCSA_ELF_TypeFunction is available on all
targets using getSymbolPreferLocal.

[arichardson]

Ah nice was not aware that this was allowed without checking (I believe there was/is another place I copied this from).

LGTM. And if this wasn't NFC it would have noticed by the tests.

I can see a few other placs that check for MAI->hasDotTypeDotSizeDirective() before calling emitSymbolAttribute(). Should those be simplified as well as part of this PR or as a separate one?

[arichardson]

Similarly, I wonder if we could change all the guarded OutStreamer->emitELFSize to just OutStreamer->emitSymbolSize() and make that a non-op on unsupported platforms. The emitELFSize() appears to be misnamed since e.g. WASM also sets the size.

[MaskRay]

Similarly, I wonder if we could change all the guarded OutStreamer->emitELFSize to just OutStreamer->emitSymbolSize() and make that a non-op on unsupported platforms. The emitELFSize() appears to be misnamed since e.g. WASM also sets the size.

Thanks for the suggestion. Let me explore this as a potential simplification...

edit: I think we still need MAI->hasDotTypeDotSizeDirective(). Some call sites create non-trivial MCExpr or call emitLabel, which should not run for other targets.