Skip to content

[lldb][cmake] Use STATUS instead of explicit '--' in message logging #128196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged

[lldb][cmake] Use STATUS instead of explicit '--' in message logging #128196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4683735
Use STATUS instead of explicit '--' in MESSAGE
Feb 21, 2025
c8405f6
Use message in lower case
Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lldb/source/API/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,23 +206,23 @@ if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows")
# If we're not exporting all symbols, we'll want to explicitly set
# the exported symbols here. This prevents 'log enable --stack ...'
# from working on some systems but limits the liblldb size.
MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb namespace")
message(STATUS "Symbols (liblldb): exporting all symbols from the lldb namespace")
add_llvm_symbol_exports(liblldb ${CMAKE_CURRENT_SOURCE_DIR}/liblldb.exports)
elseif (NOT LLDB_EXPORT_ALL_SYMBOLS_EXPORTS_FILE)
# Don't use an explicit export. Instead, tell the linker to export all symbols.
MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces")
MESSAGE(WARNING "Private LLDB symbols frequently change and no API stability is guaranteed. "
message(STATUS "Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces")
message(WARNING "Private LLDB symbols frequently change and no API stability is guaranteed. "
"Only the SB API is guaranteed to be stable.")
add_llvm_symbol_exports(liblldb ${CMAKE_CURRENT_SOURCE_DIR}/liblldb-private.exports)
else ()
MESSAGE("-- Symbols (liblldb): exporting all symbols specified in the exports "
message(STATUS "Symbols (liblldb): exporting all symbols specified in the exports "
" file '${LLDB_EXPORT_ALL_SYMBOLS_EXPORTS_FILE}'")
MESSAGE(WARNING "Private LLDB symbols frequently change and no API stability is guaranteed. "
message(WARNING "Private LLDB symbols frequently change and no API stability is guaranteed. "
"Only the SB API is guaranteed to be stable.")
add_llvm_symbol_exports(liblldb "${LLDB_EXPORT_ALL_SYMBOLS_EXPORTS_FILE}")
endif()
elseif (LLDB_EXPORT_ALL_SYMBOLS)
MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces")
message(STATUS "Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces")

# Pull out the various lldb libraries linked into liblldb, these will be used
# when looking for symbols to extract. We ignore most plugin libraries here,
Expand Down