Skip to content

[libc++] Synchronize Docker container SHA in run-buildbot-container #128225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Feb 21, 2025

We should really find a way to have a canonical location for that SHA, but last time I looked into it I failed to find a way to share it.

We should really find a way to have a canonical location for that SHA,
but last time I looked into it I failed to find a way to share it.
@ldionne ldionne requested a review from a team as a code owner February 21, 2025 20:07
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Feb 21, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 21, 2025

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

We should really find a way to have a canonical location for that SHA, but last time I looked into it I failed to find a way to share it.


Full diff: https://github.com/llvm/llvm-project/pull/128225.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/run-buildbot-container (+2-2)
diff --git a/libcxx/utils/ci/run-buildbot-container b/libcxx/utils/ci/run-buildbot-container
index b4391455e2725..b6c0817e86f72 100755
--- a/libcxx/utils/ci/run-buildbot-container
+++ b/libcxx/utils/ci/run-buildbot-container
@@ -26,6 +26,6 @@ if [[ ! -d "${MONOREPO_ROOT}/libcxx/utils/ci" ]]; then
     echo "Was unable to find the root of the LLVM monorepo; are you running from within the monorepo?"
     exit 1
 fi
-docker pull ghcr.io/llvm/libcxx-linux-builder:0fd6f684b9c84c32d6cbfd9742402e788b2879f1
-docker run -it --volume "${MONOREPO_ROOT}:/llvm" --workdir "/llvm" --cap-add=SYS_PTRACE ghcr.io/llvm/libcxx-linux-builder:0fd6f684b9c84c32d6cbfd9742402e788b2879f1 \
+docker pull ghcr.io/llvm/libcxx-linux-builder:b319dfef21f6c7b0bc6a356d6b9f41a3b3b98ae9
+docker run -it --volume "${MONOREPO_ROOT}:/llvm" --workdir "/llvm" --cap-add=SYS_PTRACE ghcr.io/llvm/libcxx-linux-builder:b319dfef21f6c7b0bc6a356d6b9f41a3b3b98ae9 \
     bash -c 'git config --global --add safe.directory /llvm ; exec bash'

@ldionne ldionne merged commit de473fc into llvm:main Feb 24, 2025
88 checks passed
@ldionne ldionne deleted the review/update-docker-version-in-tools branch February 24, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants