Skip to content

[Github][CI] Name Premerge Jobs Experimental #128227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

boomanaiden154
Copy link
Contributor

As discussed on Discourse (https://discourse.llvm.org/t/googles-plan-for-the-llvm-presubmit-infrastructure/78940/8), this patch renames the premerge jobs to include experimental in them to hopefully better signal that these are still a prototype. This patch does not mark the MacOS job as experimental as that is being used in production on the release branch.

As discussed on Discourse (https://discourse.llvm.org/t/googles-plan-for-the-llvm-presubmit-infrastructure/78940/8),
this patch renames the premerge jobs to include experimental in them to
hopefully better signal that these are still a prototype. This patch
does not mark the MacOS job as experimental as that is being used in
production on the release branch.
@llvmbot
Copy link
Member

llvmbot commented Feb 21, 2025

@llvm/pr-subscribers-github-workflow

Author: Aiden Grossman (boomanaiden154)

Changes

As discussed on Discourse (https://discourse.llvm.org/t/googles-plan-for-the-llvm-presubmit-infrastructure/78940/8), this patch renames the premerge jobs to include experimental in them to hopefully better signal that these are still a prototype. This patch does not mark the MacOS job as experimental as that is being used in production on the release branch.


Full diff: https://github.com/llvm/llvm-project/pull/128227.diff

1 Files Affected:

  • (modified) .github/workflows/premerge.yaml (+3)
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 2d366028c2337..c06631c458fe1 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -25,6 +25,7 @@ concurrency:
 
 jobs:
   premerge-checks-linux:
+    name: Linux Premerge Checks (Experimental)
     if: >-
         github.repository_owner == 'llvm' &&
         (github.event_name != 'pull_request' || github.event.action != 'closed')
@@ -83,6 +84,7 @@ jobs:
           ./.ci/monolithic-linux.sh "$(echo ${linux_projects} | tr ' ' ';')" "$(echo ${linux_check_targets})" "$(echo ${linux_runtimes} | tr ' ' ';')" "$(echo ${linux_runtime_check_targets})"
 
   premerge-checks-windows:
+    name: Windows Premerge Checks (Experimental)
     if: >-
         github.repository_owner == 'llvm' &&
         (github.event_name != 'pull_request' || github.event.action != 'closed')
@@ -143,6 +145,7 @@ jobs:
           bash .ci/monolithic-windows.sh "${{ steps.vars.outputs.windows-projects }}" "${{ steps.vars.outputs.windows-check-targets }}"
 
   premerge-check-macos:
+    name: MacOS Premerge Checks
     runs-on: macos-14
     if: >-
       github.repository_owner == 'llvm' &&

@boomanaiden154 boomanaiden154 merged commit b9e25f6 into llvm:main Feb 22, 2025
8 of 9 checks passed
@boomanaiden154 boomanaiden154 deleted the premerge-naming-experimental branch February 22, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants