Skip to content

[lldb-dap] skip TestDAP_server on windows to unblock CI. #128278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

ashgti
Copy link
Contributor

@ashgti ashgti commented Feb 22, 2025

This should fix the tests running on windows.

https://lab.llvm.org/buildbot/#/builders/141/builds/6506 is the failure, the error message does not clearly indicate why the connection failed, but they are passing for me locally on macOS and passed on linux in the CI.

@ashgti ashgti marked this pull request as ready for review February 22, 2025 03:46
@ashgti ashgti requested a review from JDevlieghere as a code owner February 22, 2025 03:46
@llvmbot llvmbot added the lldb label Feb 22, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 22, 2025

@llvm/pr-subscribers-lldb

Author: John Harrison (ashgti)

Changes

This should fix the tests running on windows.

https://lab.llvm.org/buildbot/#/builders/141/builds/6506 is the failure, the error message does not clearly indicate why the connection failed.


Full diff: https://github.com/llvm/llvm-project/pull/128278.diff

1 Files Affected:

  • (modified) lldb/test/API/tools/lldb-dap/server/TestDAP_server.py (+1)
diff --git a/lldb/test/API/tools/lldb-dap/server/TestDAP_server.py b/lldb/test/API/tools/lldb-dap/server/TestDAP_server.py
index e78fdceed1bbd..1f562e989533a 100644
--- a/lldb/test/API/tools/lldb-dap/server/TestDAP_server.py
+++ b/lldb/test/API/tools/lldb-dap/server/TestDAP_server.py
@@ -48,6 +48,7 @@ def run_debug_session(self, connection, name):
         self.assertEqual(output, f"Hello {name}!\r\n")
         self.dap_server.request_disconnect()
 
+    @skipIfWindows
     def test_server_port(self):
         """
         Test launching a binary with a lldb-dap in server mode on a specific port.

@ashgti ashgti changed the title [lldb-da] skip TestDAP_server on windows to unblock CI. [lldb-dap] skip TestDAP_server on windows to unblock CI. Feb 22, 2025
@ashgti ashgti merged commit 664cbd1 into llvm:main Feb 24, 2025
14 checks passed
@ashgti ashgti deleted the lldb-dap-fix-socket-timeout branch February 24, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants